unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 62564@debbugs.gnu.org
Subject: [bug#62564] patches to fix age after update to v1.1.1
Date: Sat, 1 Apr 2023 12:40:19 -0400	[thread overview]
Message-ID: <ZChec2O9xNf1qBOx@jasmine.lan> (raw)
In-Reply-To: <87lejcf2wq.fsf@ngraves.fr>

On Sat, Apr 01, 2023 at 10:00:05AM +0200, Nicolas Graves via Guix-patches via wrote:
> So, in order for other concerned packages to build properly, I had to
> update a few other packages. The v3 patches seem to build fine on
> https://qa.guix.gnu.org/issue/62564, I guess it should be alright to get
> them merged.

Thanks for this patch series!

Overall, it looks good, but there are still some cosmetic issues to fix.

For each commit, please make the commit message fully describe the
changes. For example, in patch 4/14, the commit message does not mention
the changed dependencies in native-inputs. Take a look at the commit log
for examples of what to write, e.g.:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=113146d31c91e1951f469aa974fef9c0413080a8

In several of the patches that add a new package, the new package
variable is added without any space before the subsequent package
variable. Please ensure that all new packages have a newline before and
after the new variable.

Beyond these cosmetic issues, the changes look good to me.




  reply	other threads:[~2023-04-01 16:41 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  7:32 [bug#62564] patches to fix age after update to v1.1.1 Nicolas Graves via Guix-patches via
2023-03-31  7:37 ` [bug#62564] [PATCH 1/2] gnu: go-golang-org-x-crypto: Update to 0.4.0 Nicolas Graves via Guix-patches via
2023-03-31  7:37   ` [bug#62564] [PATCH 2/2] gnu: go-golang-org-x-term: Update to 0.3.0 Nicolas Graves via Guix-patches via
2023-03-31 18:11 ` [bug#62564] [PATCH v2 1/6] gnu: Remove go-github.com-howeyc-gopass Nicolas Graves via Guix-patches via
2023-03-31 18:11   ` [bug#62564] [PATCH v2 2/6] gnu: go-golang-org-x-crypto: Update to 0.4.0 Nicolas Graves via Guix-patches via
2023-03-31 18:11   ` [bug#62564] [PATCH v2 3/6] gnu: go-golang-org-x-term: Update to 0.3.0 Nicolas Graves via Guix-patches via
2023-03-31 18:11   ` [bug#62564] [PATCH v2 4/6] gnu: go-github-com-99designs-go-keyring: Update to 1.2.2 Nicolas Graves via Guix-patches via
2023-03-31 18:11   ` [bug#62564] [PATCH v2 5/6] gnu: pixterm: Add input go-golang-go-x-term Nicolas Graves via Guix-patches via
2023-03-31 18:11   ` [bug#62564] [PATCH v2 6/6] gnu: curlie: Add input go-golang-x-term Nicolas Graves via Guix-patches via
2023-03-31 19:17 ` [bug#62564] [PATCH v3 01/14] gnu: Remove go-github.com-howeyc-gopass Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 02/14] gnu: go-golang-org-x-crypto: Update to 0.4.0 Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 03/14] gnu: go-golang-org-x-term: Update to 0.3.0 Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 04/14] gnu: go-github-com-99designs-go-keyring: Update to 1.2.2 Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 05/14] gnu: pixterm: Add input go-golang-go-x-term Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 06/14] gnu: curlie: Add input go-golang-x-term Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 07/14] gnu: Add go-github-com-aws-smithy-go Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 08/14] gnu: Add go-github-com-aws-aws-sdk-go-v2 Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 09/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-config Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 10/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-iam Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 11/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sso Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 12/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-ssooidc Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 13/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sts Nicolas Graves via Guix-patches via
2023-03-31 19:17   ` [bug#62564] [PATCH v3 14/14] gnu: aws-vault: Update to 6.6.2 Nicolas Graves via Guix-patches via
2023-04-01  8:00 ` [bug#62564] patches to fix age after update to v1.1.1 Nicolas Graves via Guix-patches via
2023-04-01 16:40   ` Leo Famulari [this message]
2023-04-17  7:32 ` [bug#62564] [PATCH v4 01/14] gnu: Remove go-github.com-howeyc-gopass Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 02/14] gnu: go-golang-org-x-crypto: Update to 0.4.0 Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 03/14] gnu: go-golang-org-x-term: Update to 0.3.0 Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 04/14] gnu: go-github-com-99designs-go-keyring: Update to 1.2.2 Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 05/14] gnu: pixterm: Add input go-golang-org-x-term Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 06/14] gnu: curlie: " Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 07/14] gnu: Add go-github-com-aws-smithy-go Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 08/14] gnu: Add go-github-com-aws-aws-sdk-go-v2 Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 09/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-config Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 10/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-iam Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 11/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sso Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 12/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-ssooidc Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 13/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sts Nicolas Graves via Guix-patches via
2023-04-17  7:32   ` [bug#62564] [PATCH v4 14/14] gnu: aws-vault: Update to 6.6.2 Nicolas Graves via Guix-patches via
2023-04-22 16:18     ` Nicolas Graves via Guix-patches via
2023-04-22 16:13 ` [bug#62564] [PATCH v5 01/14] gnu: Remove go-github.com-howeyc-gopass Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 02/14] gnu: go-golang-org-x-crypto: Update to 0.4.0 Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 03/14] gnu: go-golang-org-x-term: Update to 0.3.0 Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 04/14] gnu: go-github-com-99designs-go-keyring: Update to 1.2.2 Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 05/14] gnu: pixterm: Add input go-golang-org-x-term Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 06/14] gnu: curlie: " Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 07/14] gnu: Add go-github-com-aws-smithy-go Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 08/14] gnu: Add go-github-com-aws-aws-sdk-go-v2 Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 09/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-config Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 10/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-iam Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 11/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sso Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 12/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-ssooidc Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 13/14] gnu: Add go-github-com-aws-aws-sdk-go-v2-service-sts Nicolas Graves via Guix-patches via
2023-04-22 16:13   ` [bug#62564] [PATCH v5 14/14] gnu: aws-vault: Update to 6.6.2 Nicolas Graves via Guix-patches via
2023-04-23 14:56   ` [bug#62564] [PATCH v5 01/14] gnu: Remove go-github.com-howeyc-gopass Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZChec2O9xNf1qBOx@jasmine.lan \
    --to=leo@famulari.name \
    --cc=62564@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).