From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0AosA6teKGTe/AAASxT56A (envelope-from ) for ; Sat, 01 Apr 2023 18:41:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KIYcA6teKGQqJAAA9RJhRA (envelope-from ) for ; Sat, 01 Apr 2023 18:41:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A594C389DC for ; Sat, 1 Apr 2023 18:41:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pieHo-0001v5-3z; Sat, 01 Apr 2023 12:41:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pieHm-0001ug-CR for guix-patches@gnu.org; Sat, 01 Apr 2023 12:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pieHm-0006DH-36 for guix-patches@gnu.org; Sat, 01 Apr 2023 12:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pieHl-0007q9-V1 for guix-patches@gnu.org; Sat, 01 Apr 2023 12:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62564] patches to fix age after update to v1.1.1 Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Apr 2023 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62564 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 62564@debbugs.gnu.org X-Debbugs-Original-To: Nicolas Graves via Guix-patches via X-Debbugs-Original-Cc: 62564@debbugs.gnu.org Received: via spool by 62564-submit@debbugs.gnu.org id=B62564.168036723130080 (code B ref 62564); Sat, 01 Apr 2023 16:41:01 +0000 Received: (at 62564) by debbugs.gnu.org; 1 Apr 2023 16:40:31 +0000 Received: from localhost ([127.0.0.1]:38479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pieHG-0007p1-JQ for submit@debbugs.gnu.org; Sat, 01 Apr 2023 12:40:30 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pieHF-0007od-0b for 62564@debbugs.gnu.org; Sat, 01 Apr 2023 12:40:29 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 535E83200961; Sat, 1 Apr 2023 12:40:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 01 Apr 2023 12:40:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1680367222; x=1680453622; bh=2NDRx0uvTUFe1IA5SL8CbLYLNsEAew2vUw8sCI31ZY8=; b= o5eel0eYt38Zdvf3bsnVMiXJIqOQLvqa+OEo/pi7qvksU2zxqooV5wxV8vOyzV6U /+640VmYKm/vyQG7t17u1GNsi3vM3oHIPa2ezH+hAq/WGTLPNxoHULb6sNMSdTby 0Fh2QkzF92FlVh90cCN34X4+nkUHw5QqimhEyID5ywk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680367222; x=1680453622; bh=2NDRx0uvTUFe1 IA5SL8CbLYLNsEAew2vUw8sCI31ZY8=; b=CD0Lxn+mRIEBNGOeJJnmfmTEyPXN3 RZBGjV180negidskprA2uVz01L5qI+xUwBlGThFkiCcHuLmD0JdxS5z+Pl6K654P wqJIOi8myxBThN8sId5iygsStByEXpE/EDADTpe7BOt+wa0yjxE6NxMAgWzp5u+J yjHlbYUN03m1xFHqg/DOZVdtFELDvy15kTBoHQBufk4PK35P/xXg0c27xWZknWkk LEXSuDpNZ5DDUJMwAHjQtqyS1BFyItNoqDwi6D7W9OAVDXOuTrCV6VeuNvj0hQc5 uQw2G+Yt1sqsKEuY87hKkDxpDJYGXrSJ4/LLLkqq5IF73e7v/PqXK22UQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeifedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeetheeuvdeivdelueeukefhtdeihedtgefhvddvlefhudejudeiheelfeev teeuhfenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Apr 2023 12:40:21 -0400 (EDT) Date: Sat, 1 Apr 2023 12:40:19 -0400 From: Leo Famulari Message-ID: References: <87ilehwf2v.fsf@ngraves.fr> <87lejcf2wq.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lejcf2wq.fsf@ngraves.fr> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680367274; a=rsa-sha256; cv=none; b=UtoJ5rkgPu46vFL/+l+VrwFtm0rtepoo3MONP3wyH8rWrOA2tM3fBDRXgxCTEX8NPF40cX 7JXwzMyFvoPWvhsaCjt31aibRaTzb+c7NyBNIGNjChjwn5kQlyg42FOJCBOaq1tBqQ2Req zJMCakjZBlca3kstSaW/xyyOeL5M6H2SQkHbnQIQzyfSZBs2e0alGc31/4ae2IZ8cWz1wT fYZ/z+NoGDhzmpMYMZpH9k/wlYhGzmlzTkZdb6aI+t1cGrqMwtFzppS3KnfHWFoAe9AydG PrTsCGsE5kgOX3Jjju1NVSbpbB5y2hhpiFPC1CYKkKABu1z11/ud7BZLN3fC+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=o5eel0eY; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=CD0Lxn+m; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680367274; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2NDRx0uvTUFe1IA5SL8CbLYLNsEAew2vUw8sCI31ZY8=; b=GyVclWuqI0mu223f1c/1rYmyQmuXooiJuZtSxVrtFSGzKbzOW0x/vnbaEVMku9CSYB9MVn MVS/2Fq86L9YC+tg7lz7tkMXtuNVrAW67gDCvi4rgVZ4T4lZosLm8yeE9zgO/PDfk51QIG XVUPPBaJ9j54jdYDIIcH5znGn5Jlld1vTkBbxm/SFNIJ3YvJdJWCap7av4zy5DCVC16Gqz T2t3w1lyNiHzAxWtqB1cEqglYeUoWaPWdh4k6lt0zVHk2R6CJcwSxWbYmRyW4qm6XSRuVN u1YNDASiq7iWc7vu84U/41b51g5MuSeOlAOSp/vdO8pZ2fWpfhDlw9o1qKJWsw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=o5eel0eY; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=CD0Lxn+m; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.03 X-Spam-Score: -3.03 X-Migadu-Queue-Id: A594C389DC X-TUID: +Up+tedgoGvP On Sat, Apr 01, 2023 at 10:00:05AM +0200, Nicolas Graves via Guix-patches via wrote: > So, in order for other concerned packages to build properly, I had to > update a few other packages. The v3 patches seem to build fine on > https://qa.guix.gnu.org/issue/62564, I guess it should be alright to get > them merged. Thanks for this patch series! Overall, it looks good, but there are still some cosmetic issues to fix. For each commit, please make the commit message fully describe the changes. For example, in patch 4/14, the commit message does not mention the changed dependencies in native-inputs. Take a look at the commit log for examples of what to write, e.g.: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=113146d31c91e1951f469aa974fef9c0413080a8 In several of the patches that add a new package, the new package variable is added without any space before the subsequent package variable. Please ensure that all new packages have a newline before and after the new variable. Beyond these cosmetic issues, the changes look good to me.