unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#55868] [PATCH] gnu: r-prereg: Add TeXLive dependencies.
@ 2022-06-09 12:26 Lars-Dominik Braun
  2022-06-09 15:42 ` Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Lars-Dominik Braun @ 2022-06-09 12:26 UTC (permalink / raw)
  To: 55868; +Cc: rekado

* gnu/packages/cran.scm (r-prereg)[propagated-inputs]: Add
texlive-amsfonts, texlive-amsmath, texlive-booktabs,
texlive-etoolbox, texlive-generic-iftex, texlive-latex-fancyhdr,
texlive-latex-fancyvrb, texlive-latex-geometry, texlive-latex-graphics,
texlive-latex-threeparttable, texlive-latex-titlesec,
texlive-latex-upquote, texlive-listings, texlive-lm, texlive-polyglossia,
texlive-titling, texlive-tools, texlive-ulem.
---
 gnu/packages/cran.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 0299e0041e..c1f0dc08b7 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -104,6 +104,7 @@ (define-module (gnu packages cran)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages statistics)
   #:use-module (gnu packages tcl)
+  #:use-module (gnu packages tex)
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages uglifyjs)
@@ -30466,7 +30467,26 @@ (define-public r-prereg
     (properties `((upstream-name . "prereg")))
     (build-system r-build-system)
     (propagated-inputs
-      (list r-rmarkdown))
+      (list r-rmarkdown
+            ;; The package provides a custom LaTex template in
+            ;; inst/rmd/prereg_form.tex, which depends on these packages:
+            texlive-amsmath
+            texlive-booktabs
+            texlive-etoolbox
+            texlive-generic-iftex
+            texlive-latex-fancyhdr
+            texlive-latex-fancyvrb
+            texlive-latex-geometry
+            texlive-latex-graphics
+            texlive-latex-threeparttable
+            texlive-latex-titlesec
+            texlive-latex-upquote
+            texlive-listings
+            texlive-polyglossia
+            texlive-titling
+            texlive-tools
+            texlive-ulem
+            (texlive-updmap.cfg (list texlive-amsfonts texlive-lm))))
     (home-page "https://github.com/crsh/prereg")
     (synopsis
       "R Markdown Templates to preregister Scientific Studies")
-- 
2.35.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#55868] [PATCH] gnu: r-prereg: Add TeXLive dependencies.
  2022-06-09 12:26 [bug#55868] [PATCH] gnu: r-prereg: Add TeXLive dependencies Lars-Dominik Braun
@ 2022-06-09 15:42 ` Ricardo Wurmus
  2022-06-10  7:09   ` Lars-Dominik Braun
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2022-06-09 15:42 UTC (permalink / raw)
  To: Lars-Dominik Braun; +Cc: 55868


Lars-Dominik Braun <lars@6xq.net> writes:

> +            (texlive-updmap.cfg (list texlive-amsfonts texlive-lm))))

What’s up with this one?  texlive-updmap.cfg isn’t supposed to be
propagated.  Why is it used with only these two texlive-* packages?

Should texlive-amsfonts and texlive-lm be moved one level up to
propagated-inputs instead, and texlive-updmap.cfg be removed?

-- 
Ricardo




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#55868] [PATCH] gnu: r-prereg: Add TeXLive dependencies.
  2022-06-09 15:42 ` Ricardo Wurmus
@ 2022-06-10  7:09   ` Lars-Dominik Braun
  2022-06-10 15:57     ` bug#55868: " Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Lars-Dominik Braun @ 2022-06-10  7:09 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 55868

Hi Ricardo,

> > +            (texlive-updmap.cfg (list texlive-amsfonts texlive-lm))))
> 
> What’s up with this one?  texlive-updmap.cfg isn’t supposed to be
> propagated.  Why is it used with only these two texlive-* packages?
my understanding was that texlive-updmap.cfg is only useful for font
packages. Why is it not supposed to be propagated? I looked at
python-nbconvert as a reference, which does the same thing.

Cheers,
Lars





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#55868: [PATCH] gnu: r-prereg: Add TeXLive dependencies.
  2022-06-10  7:09   ` Lars-Dominik Braun
@ 2022-06-10 15:57     ` Ricardo Wurmus
  0 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2022-06-10 15:57 UTC (permalink / raw)
  To: Lars-Dominik Braun; +Cc: 55868-done


Lars-Dominik Braun <lars@6xq.net> writes:

> Hi Ricardo,
>
>> > +            (texlive-updmap.cfg (list texlive-amsfonts texlive-lm))))
>> 
>> What’s up with this one?  texlive-updmap.cfg isn’t supposed to be
>> propagated.  Why is it used with only these two texlive-* packages?
> my understanding was that texlive-updmap.cfg is only useful for font
> packages. Why is it not supposed to be propagated? I looked at
> python-nbconvert as a reference, which does the same thing.

My mistake.  I still remember texlive-union, which built a union
directory from its inputs — that union directory and its config file
could not be composed with other files or packages.  Propagating it
would have been pointless.

This texlive-union eventually gave way to texlive-updmap.cfg, which only
creates font map files, while propagating its inputs.  The font map
files should be usable as is, and since the inputs are propagated the
texlive-base profile hook can generate them anew (together with other
installed texlive-* packages) when needed.

So I guess this is fine after all.  Sorry for the noise!

I have applied your patch.

-- 
Ricardo




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-10 16:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 12:26 [bug#55868] [PATCH] gnu: r-prereg: Add TeXLive dependencies Lars-Dominik Braun
2022-06-09 15:42 ` Ricardo Wurmus
2022-06-10  7:09   ` Lars-Dominik Braun
2022-06-10 15:57     ` bug#55868: " Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).