unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54216@debbugs.gnu.org, Attila Lendvai <attila@lendvai.name>,
	zimoun <zimon.toutoune@gmail.com>
Subject: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in Guix.
Date: Sat, 5 Mar 2022 16:13:17 -0500	[thread overview]
Message-ID: <YiPSbdXBeim+5xfY@jasmine.lan> (raw)
In-Reply-To: <5d684728965ec36c604e9b77f650055269e8588e.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Thu, Mar 03, 2022 at 07:25:22AM +0100, Maxime Devos wrote:
> Leo Famulari schreef op wo 02-03-2022 om 18:50 [-0500]:
> > Origin snippets should only be used to remove nonfree things
> > from the upstream source code. All other changes should use
> > patch files or a build phase.
> 
> Why?  If it's a source code change and it fits an origin snippet,
> why not an origin snippet?  Why would the source in Guix need to match
> the source upstream?

`guix build --source` is a tool to provide freely licensed source code
to be used for any purpose, including building on systems besides Guix.

Using the Guix tools, there is no way to access the upstream source code
without applying the snippets. The reason for that is that the origin
snippet mechanism was introduced specifically to remove non-free
components without making it easy to reverse the transformation.

Compare that to patch files, which are easily reversed, and build
phases, which do not apply to `guix build --source`.

So, we have to be careful when using snippets, to ensure that the result
of `guix build --source` is useful on any system, not just Guix.

More info:
https://guix.gnu.org/manual/en/html_node/Snippets-versus-Phases.html

Please let me know if these guidelines are still unclear.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-03-05 21:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 18:28 [bug#54216] [PATCH] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-01 18:36 ` Maxime Devos
2022-03-01 18:45 ` [bug#54216] [PATCH v2] " Attila Lendvai
2022-03-01 19:01   ` Maxime Devos
2022-03-01 19:27     ` Attila Lendvai
2022-03-02  9:14       ` zimoun
2022-03-02 23:50         ` Leo Famulari
2022-03-03  6:25           ` Maxime Devos
2022-03-03  8:48             ` zimoun
2022-03-05 21:13             ` Leo Famulari [this message]
2022-03-05 21:50               ` Maxime Devos
2022-03-03 14:36         ` [bug#54216] [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Maxime Devos
2022-03-03 14:51           ` zimoun
2022-03-03  9:43 ` [bug#54216] [PATCH v3] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-03 14:28 ` [bug#54216] [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Attila Lendvai
2022-03-04 10:30 ` [bug#54216] [PATCH shepherd staging v2] " Attila Lendvai
2022-03-21 15:14 ` [bug#54216] [PATCH v4] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-21 15:41   ` [bug#54216] [PATCH] " Ludovic Courtès
2022-03-21 16:12     ` zimoun
2022-03-21 17:07 ` [bug#54216] [PATCH staging v3] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Attila Lendvai
2022-03-22  9:27   ` Attila Lendvai
2022-03-22 13:48     ` Attila Lendvai
2022-03-22 14:42       ` pelzflorian (Florian Pelz)
2022-03-28  9:07         ` Attila Lendvai
2022-05-01 14:31 ` [bug#54216] [PATCH v4] gnu: shepherd: Build Shepherd 0.9.0 from git Attila Lendvai
2022-09-26 19:11 ` [bug#54216] [PATCH v5] gnu: shepherd: Build Shepherd 0.9.2 " Attila Lendvai
2022-09-26 21:44 ` [bug#54216] [PATCH v6] " Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiPSbdXBeim+5xfY@jasmine.lan \
    --to=leo@famulari.name \
    --cc=54216@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    --cc=maximedevos@telenet.be \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).