From: zimoun <zimon.toutoune@gmail.com>
To: Attila Lendvai <attila@lendvai.name>
Cc: 54216@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in Guix.
Date: Wed, 2 Mar 2022 10:14:01 +0100 [thread overview]
Message-ID: <CAJ3okZ1vah5XFy3BVoc=hv0Ke5GxT+3M3uYo2CTNRZyPHz-mAQ@mail.gmail.com> (raw)
In-Reply-To: <aJFlM3mC27rhgpJ7Mr5IN7Zyb84HRFfGSJinSMwiKWGxoY8t6gjmUatPyK2y_S8PNSqHgnTUbGJ3NDoiNHDnjN2rHVbi80WbUntglsXEO1s=@lendvai.name>
Hi Attila,
On Tue, 1 Mar 2022 at 20:42, Attila Lendvai <attila@lendvai.name> wrote:
> unfortunately, it won't help us much here, because one snippet modifies
> Makefile.am, while the other Makefile.in.
Guix does not have a clear line for patching (or I am not aware of the
update); what is going to source+snippet vs arguments+phase. Pros and
cons for both; basically the question is what "guix build --source"
should return?
Option source+snippet means it returns the source of what Guix really
builds -- so many packages would not respect this rule of thumb.
Option arguments+phase means it returns the real unmodified upstream
source (modulo removal of non-free) -- so "guix shell -D foo" would
break for many packages.
Difficult tension. :-) For most cases, not an unique answer; maybe
that's why we do not have a clear documentation. :-) I just mention
it i.e., I am not saying you can do something. :-) I am simply
pointing that Guix does not have a clear recommendation /
documentation where the patches should go; probably depending on their
nature. Well, nothing related with your patch. :-)
That's said, personally, in this case, instead of having the Makefile*
patch in 'source', I would do the patching using a phase.
Cheers,
simon
next prev parent reply other threads:[~2022-03-02 9:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 18:28 [bug#54216] [PATCH] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-01 18:36 ` Maxime Devos
2022-03-01 18:45 ` [bug#54216] [PATCH v2] " Attila Lendvai
2022-03-01 19:01 ` Maxime Devos
2022-03-01 19:27 ` Attila Lendvai
2022-03-02 9:14 ` zimoun [this message]
2022-03-02 23:50 ` Leo Famulari
2022-03-03 6:25 ` Maxime Devos
2022-03-03 8:48 ` zimoun
2022-03-05 21:13 ` Leo Famulari
2022-03-05 21:50 ` Maxime Devos
2022-03-03 14:36 ` [bug#54216] [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Maxime Devos
2022-03-03 14:51 ` zimoun
2022-03-03 9:43 ` [bug#54216] [PATCH v3] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-03 14:28 ` [bug#54216] [PATCH staging] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Attila Lendvai
2022-03-04 10:30 ` [bug#54216] [PATCH shepherd staging v2] " Attila Lendvai
2022-03-21 15:14 ` [bug#54216] [PATCH v4] gnu: shepherd-for-guix: New package for use in Guix Attila Lendvai
2022-03-21 15:41 ` [bug#54216] [PATCH] " Ludovic Courtès
2022-03-21 16:12 ` zimoun
2022-03-21 17:07 ` [bug#54216] [PATCH staging v3] gnu: shepherd: Build it from git, and clean up shepherd-for-guix Attila Lendvai
2022-03-22 9:27 ` Attila Lendvai
2022-03-22 13:48 ` Attila Lendvai
2022-03-22 14:42 ` pelzflorian (Florian Pelz)
2022-03-28 9:07 ` Attila Lendvai
2022-05-01 14:31 ` [bug#54216] [PATCH v4] gnu: shepherd: Build Shepherd 0.9.0 from git Attila Lendvai
2022-09-26 19:11 ` [bug#54216] [PATCH v5] gnu: shepherd: Build Shepherd 0.9.2 " Attila Lendvai
2022-09-26 21:44 ` [bug#54216] [PATCH v6] " Attila Lendvai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ1vah5XFy3BVoc=hv0Ke5GxT+3M3uYo2CTNRZyPHz-mAQ@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=54216@debbugs.gnu.org \
--cc=attila@lendvai.name \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).