unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tissevert <tissevert+guix@marvid.fr>
To: 48126@debbugs.gnu.org
Cc: Tobias Geerinckx-Rice <me@tobias.gr>
Subject: [bug#48126] [PATCH] Add package for vim-solarized
Date: Fri, 14 May 2021 19:10:28 +0200	[thread overview]
Message-ID: <YJ6uzf8fHcTJwC+m@hellebore> (raw)
In-Reply-To: <YJG0+36fywEZ4cjT@hellebore>

[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]

Hey,

This time I think the 2nd version of the patch has the right format. Actually
it's kind of a 3rd version because there was still an indentation problem (tabs
had creeped undected as far as my package's description) and a repetition in
the text.

And I have no idea why using etc/indent-code.el had broken the whole file last
time, it's worked fine and has modified only my region this time. So, it was
still useful practice for me : ) And I really hope it's good this time : )

Kind regards,

Tissevert

Le Tue, May 04, 2021 at 10:56:27PM +0200, Tissevert a écrit :
> Hello !
> 
> Thanks a lot for all your feedback.
> 
> It took me a little while but I think I've improved my first patch proposal. I
> had tried to indent the code automatically like mentioned in the video tutorial
> using etc/indent-code.el but obviously this had failed. Maybe I overwrote the
> changes with vim ? Anyway, I tried doing it again but there are many other
> badly indented blocks in the rest of the file so it is hard to do and retain
> only what is in my new package. So I've done it twice during the process, but
> it could still be a little weird.
> 
> I changed the source to use the main «heavy» repos, and since it has a release
> tag but the actual commit corresponding to this tag is a little behind the
> current state (I checked the diff, it has changes to the vim files, not just
> the documentation) so I used the latest commit as target to be sure the most
> recent changes were included in the package even though I still call it by the
> name of the most recent tag.
> 
> So here goes.
> 
> Kind regards,
> 
> Tissevert
> 
> 

[-- Attachment #2: 0001-Add-package-for-vim-solarized.patch --]
[-- Type: text/plain, Size: 2484 bytes --]

From 23f26c93fca3a5468774e419e07a9efb82339214 Mon Sep 17 00:00:00 2001
From: Tissevert <tissevert+guix@marvid.fr>
Date: Fri, 30 Apr 2021 19:04:35 +0200
Subject: [PATCH] Add package for vim-solarized

---
 gnu/packages/vim.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 47ac984fc7..9e1eaa7fbd 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2019, 2020 Jakub Kądziołka <kuba@kadziolka.net>
 ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2021 Tissevert <tissevert+guix@marvid.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -579,6 +580,41 @@ are detected, the user is notified.")
     (home-page "https://github.com/vim-syntastic/syntastic")
     (license license:wtfpl2)))
 
+(define-public vim-solarized
+  (let ((commit "62f656a02f93c5190a8753159e34b385588d5ff3")
+        (revision "1"))
+    (package
+      (name "vim-solarized")
+      (version (git-version "v1.0.0beta1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/altercation/vim-colors-solarized")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0001mz5v3a8zvi3gzmxhi3yrsb6hs7qf6i497arsngnvj2cwn61d"))))
+      (build-system copy-build-system)
+      (arguments
+       '(#:install-plan
+         '(("vim-colors-solarized/colors" "share/vim/vimfiles/")
+           ("vim-colors-solarized/doc" "share/vim/vimfiles/"))))
+      (home-page "https://github.com/altercation/vim-colors-solarized")
+      (synopsis "Solarized color scheme for Vim")
+      (description
+       "Solarized is a 16-color palette comprising 8 monotones and 8 accent
+colors.  It was designed for use with both terminal and GUI applicatins, and
+has a dark and a light mode.
+
+Based on CIELAB lightness relationships between colors, this theme reduces
+brightness contrast but retains contrasting hues based on colorwheel relations
+for syntax highlighting readability.
+
+It keeps the same selective contrast relationships and overall feel when
+switching between the light and dark background modes.")
+      (license license:expat))))
+
 (define-public editorconfig-vim
   (package
     (name "editorconfig-vim")
-- 
2.31.1


  reply	other threads:[~2021-05-14 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 17:42 [bug#48126] [PATCH] Add package for vim-solarized Tissevert
2021-04-30 20:44 ` Tissevert
2021-04-30 22:06   ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-30 23:20 ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-30 23:27   ` Tobias Geerinckx-Rice via Guix-patches via
2021-05-04 20:56     ` Tissevert
2021-05-14 17:10       ` Tissevert [this message]
2021-05-14 18:25         ` Thiago Jung Bauermann via Guix-patches via
2021-05-14 20:33           ` Tissevert
2021-05-15 13:04 ` bug#48126: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ6uzf8fHcTJwC+m@hellebore \
    --to=tissevert+guix@marvid.fr \
    --cc=48126@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).