unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: 48126@debbugs.gnu.org
Cc: Tobias Geerinckx-Rice <me@tobias.gr>,
	Tissevert <tissevert+guix@marvid.fr>
Subject: [bug#48126] [PATCH] Add package for vim-solarized
Date: Fri, 14 May 2021 15:25:44 -0300	[thread overview]
Message-ID: <1655254.02rAZkHj1U@popigai> (raw)
In-Reply-To: <YJ6uzf8fHcTJwC+m@hellebore>

Hello Tissevert,

Em sexta-feira, 14 de maio de 2021, às 14:10:28 -03, Tissevert escreveu:
> Hey,
> 
> This time I think the 2nd version of the patch has the right format.
> Actually it's kind of a 3rd version because there was still an
> indentation problem (tabs had creeped undected as far as my package's
> description) and a repetition in the text.
> 
> And I have no idea why using etc/indent-code.el had broken the whole file
> last time, it's worked fine and has modified only my region this time.
> So, it was still useful practice for me : ) And I really hope it's good
> this time : )

I can't comment on the package itself, but I hope you don't mind me 
pointing out a minor nit:

> +       "Solarized is a 16-color palette comprising 8 monotones and 8
> accent +colors.  It was designed for use with both terminal and GUI
> applicatins, and +has a dark and a light mode.

Typo: applications

-- 
Thanks,
Thiago






  reply	other threads:[~2021-05-14 20:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 17:42 [bug#48126] [PATCH] Add package for vim-solarized Tissevert
2021-04-30 20:44 ` Tissevert
2021-04-30 22:06   ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-30 23:20 ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-30 23:27   ` Tobias Geerinckx-Rice via Guix-patches via
2021-05-04 20:56     ` Tissevert
2021-05-14 17:10       ` Tissevert
2021-05-14 18:25         ` Thiago Jung Bauermann via Guix-patches via [this message]
2021-05-14 20:33           ` Tissevert
2021-05-15 13:04 ` bug#48126: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1655254.02rAZkHj1U@popigai \
    --to=guix-patches@gnu.org \
    --cc=48126@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    --cc=me@tobias.gr \
    --cc=tissevert+guix@marvid.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).