From: Lars-Dominik Braun <lars@6xq.net>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 45712@debbugs.gnu.org
Subject: [bug#45712] [PATCHES] Improve Python package quality
Date: Mon, 1 Feb 2021 08:20:45 +0100 [thread overview]
Message-ID: <YBerzU9YrzFoCl9J@noor.fritz.box> (raw)
In-Reply-To: <87h7mzyg39.fsf_-_@gmail.com>
Hi Maxim,
> Oh yes, sorry I had failed to mention it, this is on the
> cu/farewell-to-pythonpath branch, which is the integration of
> GUIX_PYTHONPATH and this work of yours. I've included your v2 patches,
> with light editing: fixed the script indentation (spot via flake8), I
> removed the python2 tests as Python 2 is obsolete, and removed the space
> between the (procedure)[area/conditional] part of the GNU changelog
> commit messages.
thanks!
> Another note to help with review; when sending v2 patches, make sure the
> title of your mail reply mentions [PATCH v2]; this helps to spot the
> later versions in email threads.
Sorry about that, will do next time.
> The branch is shaping up nicely; I encourage you to try it. If no major
> problem is found with it, I'll merge it in core-updates soon.
I’ve been rebuilding packages on my list that use python-build-system
using this branch and quite a few fail, but in a random sample I found
none that fails due to this patch and also I imagine some issues are
already fixed on core-updates? Is there anything else I can do?
Cheers,
Lars
next prev parent reply other threads:[~2021-02-01 7:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 13:26 [bug#45712] [PATCHES] Improve Python package quality Lars-Dominik Braun
2021-01-08 11:37 ` Hartmut Goebel
2021-01-08 12:19 ` Ricardo Wurmus
2021-01-12 9:37 ` Lars-Dominik Braun
2021-01-25 19:29 ` Maxim Cournoyer
2021-01-26 8:39 ` Lars-Dominik Braun
2021-01-28 15:40 ` Maxim Cournoyer
2021-01-28 16:18 ` Lars-Dominik Braun
2021-01-29 14:26 ` Maxim Cournoyer
2021-02-01 7:20 ` Lars-Dominik Braun [this message]
2021-02-01 17:02 ` bug#45712: " Maxim Cournoyer
2021-02-07 16:59 ` [bug#45712] " Hartmut Goebel
2021-02-08 8:02 ` Lars-Dominik Braun
2021-01-25 14:43 ` Maxim Cournoyer
2021-01-25 19:42 ` Lars-Dominik Braun
2021-01-25 14:48 ` Maxim Cournoyer
2021-01-29 14:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBerzU9YrzFoCl9J@noor.fritz.box \
--to=lars@6xq.net \
--cc=45712@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).