From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2CHjNiqsF2DeRQAA0tVLHw (envelope-from ) for ; Mon, 01 Feb 2021 07:22:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id FkSbMiqsF2BUJAAAB5/wlQ (envelope-from ) for ; Mon, 01 Feb 2021 07:22:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 456B19403A6 for ; Mon, 1 Feb 2021 07:22:18 +0000 (UTC) Received: from localhost ([::1]:37574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6TXN-0006Bn-1U for larch@yhetil.org; Mon, 01 Feb 2021 02:22:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6TX8-00069C-L2 for guix-patches@gnu.org; Mon, 01 Feb 2021 02:22:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6TX8-0006M0-Dl for guix-patches@gnu.org; Mon, 01 Feb 2021 02:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6TX8-0006Yw-8s for guix-patches@gnu.org; Mon, 01 Feb 2021 02:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Feb 2021 07:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161216406325134 (code B ref 45712); Mon, 01 Feb 2021 07:22:02 +0000 Received: (at 45712) by debbugs.gnu.org; 1 Feb 2021 07:21:03 +0000 Received: from localhost ([127.0.0.1]:58620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6TWA-0006XJ-Va for submit@debbugs.gnu.org; Mon, 01 Feb 2021 02:21:03 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:47540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6TW5-0006WC-Bv for 45712@debbugs.gnu.org; Mon, 01 Feb 2021 02:21:01 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4DTfVp44lPzQjkp; Mon, 1 Feb 2021 08:20:50 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1612164048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jHVUu+9Hl1lFRjTclHMbgZiI1VHOV8B5tIn481WdaQQ=; b=inFeiYBK5RsOvdSCnM7ZurTWatUF5hWHiN4O2Mw/4BspjiBYBEygHCES+XPxJCRravJS5n 4MFcZXCD7g3lJFiQFjWHgFcptd06NKmnswUeIn2QXH2IijzJUpkTLWocPT9ZveuVEtA/HI 1mfXvuHTNlXxsQR8TfJrI4esKdXbJrRrOw90wJvdhFawbVqeuVjoCtXE2ZAbOvI8oZkCuf MpksFuTgF3fGCM5QDvr+iqLo1OLhVVFypnnOgUpFaXab5PIkA5EdcqFSp/3leZMn8daoBs JCFQxPr+iWW/iJNE5GBn4wS4ix9wt5zn/UPSE2VCkjSVjCf0DSyliL8hS3jnEA== Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id ZT9FuvJ7JmG3; Mon, 1 Feb 2021 08:20:47 +0100 (CET) Date: Mon, 1 Feb 2021 08:20:45 +0100 From: Lars-Dominik Braun Message-ID: References: <87czxs3jel.fsf_-_@gmail.com> <874kj1ysr9.fsf_-_@gmail.com> <87h7mzyg39.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h7mzyg39.fsf_-_@gmail.com> X-MBO-SPAM-Probability: X-Rspamd-Score: -3.91 / 15.00 / 15.00 X-Rspamd-Queue-Id: 9C11B1847 X-Rspamd-UID: 835bb2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=inFeiYBK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 456B19403A6 X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: YOy/GZMNVag7 Hi Maxim, > Oh yes, sorry I had failed to mention it, this is on the > cu/farewell-to-pythonpath branch, which is the integration of > GUIX_PYTHONPATH and this work of yours. I've included your v2 patches, > with light editing: fixed the script indentation (spot via flake8), I > removed the python2 tests as Python 2 is obsolete, and removed the space > between the (procedure)[area/conditional] part of the GNU changelog > commit messages. thanks! > Another note to help with review; when sending v2 patches, make sure the > title of your mail reply mentions [PATCH v2]; this helps to spot the > later versions in email threads. Sorry about that, will do next time. > The branch is shaping up nicely; I encourage you to try it. If no major > problem is found with it, I'll merge it in core-updates soon. I’ve been rebuilding packages on my list that use python-build-system using this branch and quite a few fail, but in a random sample I found none that fails due to this patch and also I imagine some issues are already fixed on core-updates? Is there anything else I can do? Cheers, Lars