unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "53270@debbugs.gnu.org" <53270-done@debbugs.gnu.org>,
	Maxime Devos <maximedevos@telenet.be>
Subject: [bug#53270] [PATCH] gnu: Add yubikey-oath-dmenu.
Date: Mon, 24 Jan 2022 15:46:20 +0000	[thread overview]
Message-ID: <QHjsUKi_MZiaYMzzP_pWJ-8YTah1SK6698fNWqmW149ohtv9mfWioQWBeSc2IM2M-l2DcZbiTXMcFP5aIaDIr15qA6HJ2dZxppM0LFEwVWg=@protonmail.com> (raw)
In-Reply-To: <8735ldxzx3.fsf_-_@gnu.org>

Hi,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, January 24th, 2022 at 4:10 AM, Ludovic Courtès wrote:

> > Subject: [PATCH] gnu: Add yubikey-oath-dmenu.
> > -   gnu/packages/security-token.scm (yubikey-oath-dmenu): New variable.
>
> Applied. I took the liberty to make the change below, to avoid using a
> non-literal string as the ‘substitute*’ pattern (it’s possible to use a
> non-literal string but more error prone).
>
> Thanks John and Maxime!
>

Ah, that's how you do that, I'll add that to my virtual packaging toolbox.

Thanks for pushing and thanks for the review Maxime!

John




      reply	other threads:[~2022-01-24 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 21:15 [bug#53270] [PATCH] gnu: Add yubikey-oath-dmenu John Kehayias via Guix-patches via
2022-01-14 23:01 ` [bug#53270] [PATCH v2] " John Kehayias via Guix-patches via
2022-01-15 11:27   ` Maxime Devos
2022-01-15 19:52     ` John Kehayias via Guix-patches via
2022-01-24  6:15       ` [bug#53270] [PATCH v3] " John Kehayias via Guix-patches via
2022-01-24  9:10       ` bug#53270: [PATCH] " Ludovic Courtès
2022-01-24 15:46         ` John Kehayias via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='QHjsUKi_MZiaYMzzP_pWJ-8YTah1SK6698fNWqmW149ohtv9mfWioQWBeSc2IM2M-l2DcZbiTXMcFP5aIaDIr15qA6HJ2dZxppM0LFEwVWg=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=53270-done@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).