unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: John Kehayias <john.kehayias@protonmail.com>,
	"53270@debbugs.gnu.org" <53270@debbugs.gnu.org>
Subject: [bug#53270] [PATCH v2] gnu: Add yubikey-oath-dmenu.
Date: Sat, 15 Jan 2022 12:27:24 +0100	[thread overview]
Message-ID: <3d5ccfc962993cc5d5af18e49feb23e3c14765ca.camel@telenet.be> (raw)
In-Reply-To: <hk0AcUix2YAtnZoXukuYtIQajXq-d906hpiSNkOG_INkE5zF3FIZ4_GvXMI6zRjYD7lLfe2F3_wF5x-SGAElZl6jRAmkxDEYG4FE0pMg73Y=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

John Kehayias via Guix-patches via schreef op vr 14-01-2022 om 23:01
[+0000]:
> +          (replace 'install
> +            (lambda _
> +              (invoke "make" "install"
> +                      (string-append "DESTDIR=" #$output)
> +                      "PREFIX="))))))

Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html),
so I would avoid (ab)using DESTDIR here.  Instead of this phase,
maybe do

          (replace 'install
            (lambda _
              (invoke "make" "install"
                      (string-append "PREFIX=" #$output)))))))

instead (untested)?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-01-15 11:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 21:15 [bug#53270] [PATCH] gnu: Add yubikey-oath-dmenu John Kehayias via Guix-patches via
2022-01-14 23:01 ` [bug#53270] [PATCH v2] " John Kehayias via Guix-patches via
2022-01-15 11:27   ` Maxime Devos [this message]
2022-01-15 19:52     ` John Kehayias via Guix-patches via
2022-01-24  6:15       ` [bug#53270] [PATCH v3] " John Kehayias via Guix-patches via
2022-01-24  9:10       ` bug#53270: [PATCH] " Ludovic Courtès
2022-01-24 15:46         ` [bug#53270] " John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d5ccfc962993cc5d5af18e49feb23e3c14765ca.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=53270@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).