unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#51159] [PATCH] gnu: Add vim-nerdcommenter
@ 2021-10-12 14:13 Foo Chuan Wei
  2021-10-25  7:03 ` Efraim Flashner
  2021-11-01  4:53 ` [bug#51159] [PATCH v2] " Foo Chuan Wei
  0 siblings, 2 replies; 4+ messages in thread
From: Foo Chuan Wei @ 2021-10-12 14:13 UTC (permalink / raw)
  To: 51159

* gnu/packages/vim.scm (vim-nerdcommenter): New variable.
---
 gnu/packages/vim.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 92189b7094..f668aa0867 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -1069,3 +1069,29 @@ your code every time you make a change.  @code{Vim-slime} is an attempt at
 getting some of these features into Vim.  It works with any REPL and isn't tied
 to Lisp.")
       (license license:expat))))
+
+(define-public vim-nerdcommenter
+  (package
+    (name "vim-nerdcommenter")
+    (version "2.5.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+              (url "https://github.com/preservim/nerdcommenter")
+              (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+         (base32 "0s862kzhvv9qpr7gxd3h52hczjvm55zyff5qn0z5095072pr3wjx"))))
+    (build-system copy-build-system)
+    (arguments
+      '(#:install-plan
+        '(("doc" "share/vim/vimfiles/")
+          ("plugin" "share/vim/vimfiles/"))))
+    (home-page "https://github.com/preservim/nerdcommenter")
+    (synopsis "Vim plugin for easy commenting of code")
+    (description
+      "NERD commenter is a Vim plugin that provides many different commenting
+operations and styles which are invoked via key mappings and a menu. These
+operations are available for most filetypes.")
+    (license license:cc0)))

base-commit: 35aaf1fe10488ae9ed732fb2c383d09a70c109c0
-- 
2.25.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#51159] [PATCH] gnu: Add vim-nerdcommenter
  2021-10-12 14:13 [bug#51159] [PATCH] gnu: Add vim-nerdcommenter Foo Chuan Wei
@ 2021-10-25  7:03 ` Efraim Flashner
  2021-11-01  4:53 ` [bug#51159] [PATCH v2] " Foo Chuan Wei
  1 sibling, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2021-10-25  7:03 UTC (permalink / raw)
  To: 51159

[-- Attachment #1: Type: text/plain, Size: 2264 bytes --]

I see that the latest tag is several years old and there has been
continued development since then. Does it make sense to package a newer
commit?

Also, if you add all the patches to the bottom of the file then they all
conflict with each other and it makes it harder to apply them.

On Tue, Oct 12, 2021 at 02:13:20PM +0000, Foo Chuan Wei wrote:
> * gnu/packages/vim.scm (vim-nerdcommenter): New variable.
> ---
>  gnu/packages/vim.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
> index 92189b7094..f668aa0867 100644
> --- a/gnu/packages/vim.scm
> +++ b/gnu/packages/vim.scm
> @@ -1069,3 +1069,29 @@ your code every time you make a change.  @code{Vim-slime} is an attempt at
>  getting some of these features into Vim.  It works with any REPL and isn't tied
>  to Lisp.")
>        (license license:expat))))
> +
> +(define-public vim-nerdcommenter
> +  (package
> +    (name "vim-nerdcommenter")
> +    (version "2.5.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +              (url "https://github.com/preservim/nerdcommenter")
> +              (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +         (base32 "0s862kzhvv9qpr7gxd3h52hczjvm55zyff5qn0z5095072pr3wjx"))))
> +    (build-system copy-build-system)
> +    (arguments
> +      '(#:install-plan
> +        '(("doc" "share/vim/vimfiles/")
> +          ("plugin" "share/vim/vimfiles/"))))
> +    (home-page "https://github.com/preservim/nerdcommenter")
> +    (synopsis "Vim plugin for easy commenting of code")
> +    (description
> +      "NERD commenter is a Vim plugin that provides many different commenting
> +operations and styles which are invoked via key mappings and a menu. These
> +operations are available for most filetypes.")
> +    (license license:cc0)))
> 
> base-commit: 35aaf1fe10488ae9ed732fb2c383d09a70c109c0
> -- 
> 2.25.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#51159] [PATCH v2] gnu: Add vim-nerdcommenter.
  2021-10-12 14:13 [bug#51159] [PATCH] gnu: Add vim-nerdcommenter Foo Chuan Wei
  2021-10-25  7:03 ` Efraim Flashner
@ 2021-11-01  4:53 ` Foo Chuan Wei
  2021-11-04 13:33   ` bug#51159: " Efraim Flashner
  1 sibling, 1 reply; 4+ messages in thread
From: Foo Chuan Wei @ 2021-11-01  4:53 UTC (permalink / raw)
  To: 51159

* gnu/packages/vim.scm (vim-nerdcommenter): New variable.
---
 gnu/packages/vim.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 8792e178ab..2ff043cd9c 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -1295,3 +1295,32 @@ a sidebar that displays the ctags-generated tags of the current file, ordered
 by their scope.  This means that for example methods in C++ are displayed under
 the class they are defined in.")
     (license license:vim)))
+
+(define-public vim-nerdcommenter
+  (let ((commit "a65465d321f2f8a74b2ffa540b9b87563f7e12e8")
+        (revision "1"))
+  (package
+    (name "vim-nerdcommenter")
+    (version (git-version "2.5.2" revision commit))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+              (url "https://github.com/preservim/nerdcommenter")
+              (commit commit)))
+       (file-name (git-file-name name version))
+       (sha256
+         (base32 "00ir65iv8jfbgzjmj7332fmydh0qhabbhx8zbvd3j6pgfxqpaafw"))))
+    (build-system copy-build-system)
+    (arguments
+      '(#:install-plan
+        '(("autoload" "share/vim/vimfiles/")
+          ("doc" "share/vim/vimfiles/")
+          ("plugin" "share/vim/vimfiles/"))))
+    (home-page "https://github.com/preservim/nerdcommenter")
+    (synopsis "Vim plugin for easy commenting of code")
+    (description
+      "NERD commenter is a Vim plugin that provides many different commenting
+operations and styles which are invoked via key mappings and a menu. These
+operations are available for most filetypes.")
+    (license license:cc0))))

base-commit: f3d5d572debe59839afe29683965c6df39cb782c
-- 
2.25.1





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#51159: [PATCH v2] gnu: Add vim-nerdcommenter.
  2021-11-01  4:53 ` [bug#51159] [PATCH v2] " Foo Chuan Wei
@ 2021-11-04 13:33   ` Efraim Flashner
  0 siblings, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2021-11-04 13:33 UTC (permalink / raw)
  To: 51159-done

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Patch pushed. Thanks!

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-04 13:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 14:13 [bug#51159] [PATCH] gnu: Add vim-nerdcommenter Foo Chuan Wei
2021-10-25  7:03 ` Efraim Flashner
2021-11-01  4:53 ` [bug#51159] [PATCH v2] " Foo Chuan Wei
2021-11-04 13:33   ` bug#51159: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).