unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Disseminate Dissent via Guix-patches via <guix-patches@gnu.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 52991@debbugs.gnu.org
Subject: [bug#52991] [PATCH] gnu: Add python-astral
Date: Tue, 04 Jan 2022 15:50:51 +0000	[thread overview]
Message-ID: <OQl7p6ixOMxODg7AYbOMtsHqzbFTTxvSDM-41dLDIDH3E7xFPFrLLpSYzokn46H0CjYI-Om_miypPAFByRDb9hQNGk_uEIHn95-5MHowc_k=@protonmail.com> (raw)
In-Reply-To: <27c76bb8372bf201724f26a79c30ccee9ed0d124.camel@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]

Herein are the v2 changes.

Disseminate,
Peace


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, January 4th, 2022 at 3:08 AM, Vinicius Monego <monego@posteo.net> wrote:

> Hello,
>
> > ;; FIXME The directory '/homeless-shelter/.cache/pip' or its parent
> >
> > directory is not owned or is not writable by the current user. The
> >
> > cache has been disabled. Check the permissions and owner of that
> >
> > directory. If executing pip with sudo, you should use sudo's -H flag.
>
> This can be fixed by overriding the check phase and calling pytest
>
> manually:
>
> >     (arguments
> >      `(#:phases
> >        (modify-phases %standard-phases
> >          (replace 'check
> >            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> >              (when tests?
> >                (add-installed-pythonpath inputs outputs)
> >                (invoke "python" "-m" "pytest")))))))
> >
>
> I also adjusted the inputs as:
>
> >     (native-inputs
> >      (list python-freezegun python-setuptools-scm))
> >     (propagated-inputs
> >      (list python-dataclasses python-pytest python-pytz))
> >
>
> When the package is a module, all runtime inputs should be propagated.
>
> I also removed python-requests since it was not being used.
>
> > -   (description "This is @code{astral} a Python module which
> >
> >     calculates times
> > -   for various positions of the sun: dawn, sunrise, solar noon,
> >
> >     sunset, dusk,
> >
> >     +solar elevation, solar azimuth, rahukaalam, and the phases of the
> >
> >     moon.")
>
> I'd reword it starting with "@code{astral} is a Python module ..."
>
> The indentation is also off. If you're using Emacs you can use one of
>
> its indent commands to fix it.
>
> Could you send a v2 with these changes?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-python-astral.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-python-astral.patch, Size: 2228 bytes --]

From edf40f038e037f891bc3aaede0015da064f4c0bb Mon Sep 17 00:00:00 2001
From: paladhammika <paladhammika@protonmail.com>
Date: Tue, 4 Jan 2022 10:42:24 -0500
Subject: [PATCH] gnu: Add python=astral.

---
 gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 1f9eca9a44..88966d7ecc 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -57,6 +57,7 @@ (define-module (gnu packages astronomy)
   #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages time)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages wxwidgets)
@@ -704,6 +705,36 @@ (define-public python-astropy
 astronomy and astrophysics.")
     (license license:bsd-3)))
 
+(define-public python-astral
+  (package
+   (name "python-astral")
+   (version "2.2")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri "astral" version))
+     (sha256
+      (base32 "1gkggdibccmdy9glymw3kbrkzm6svvsg0lk56hhy92y4smkrj7g4"))))
+   (build-system python-build-system)
+   (arguments
+    `(#:phases
+      (modify-phases %standard-phases
+                     (replace 'check
+                              (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+                                (when tests?
+                                  (add-installed-pythonpath inputs outputs)
+                                  (invoke "python" "-m" "pytest")))))))
+   (native-inputs
+    (list python-freezegun python-setuptools-scm))
+   (propagated-inputs
+    (list python-dataclasses python-pytest python-pytz))
+   (home-page "https://github.com/sffjunkie/astral")
+   (synopsis "Calculations for the position of the sun and moon")
+   (description "@code{Astral} a Python module which calculates times
+ for various positions of the sun: dawn, sunrise, solar noon, sunset, dusk,
+solar elevation, solar azimuth, rahukaalam, and the phases of the moon.")
+   (license license:asl2.0)))
+
 (define-public libnova
   (package
     (name "libnova")
-- 
2.34.0


  reply	other threads:[~2022-01-04 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 23:22 [bug#52991] [PATCH] gnu: Add python-astral Disseminate Dissent via Guix-patches via
2022-01-04  3:08 ` Vinicius Monego
2022-01-04 15:50   ` Disseminate Dissent via Guix-patches via [this message]
2022-01-08 22:23     ` bug#52991: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='OQl7p6ixOMxODg7AYbOMtsHqzbFTTxvSDM-41dLDIDH3E7xFPFrLLpSYzokn46H0CjYI-Om_miypPAFByRDb9hQNGk_uEIHn95-5MHowc_k=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=52991@debbugs.gnu.org \
    --cc=disseminatedissent@protonmail.com \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).