From: Vinicius Monego <monego@posteo.net>
To: Disseminate Dissent <disseminatedissent@protonmail.com>,
52991@debbugs.gnu.org
Subject: [bug#52991] [PATCH] gnu: Add python-astral
Date: Tue, 04 Jan 2022 03:08:03 +0000 [thread overview]
Message-ID: <27c76bb8372bf201724f26a79c30ccee9ed0d124.camel@posteo.net> (raw)
In-Reply-To: <jtS4Jr8yP3KtwzDSwMWqo4phajfrlJH3L6eSVV-ZkvVX7LecX7gBkXD0FEix1DibybhklN4FZfHXtJaKgFUfi5Acj-GnKqORRXTgGS2rE0s=@protonmail.com>
Hello,
> ;; FIXME The directory '/homeless-shelter/.cache/pip' or its parent
> directory is not owned or is not writable by the current user. The
> cache has been disabled. Check the permissions and owner of that
> directory. If executing pip with sudo, you should use sudo's -H flag.
This can be fixed by overriding the check phase and calling pytest
manually:
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> (replace 'check
> (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> (when tests?
> (add-installed-pythonpath inputs outputs)
> (invoke "python" "-m" "pytest")))))))
I also adjusted the inputs as:
> (native-inputs
> (list python-freezegun python-setuptools-scm))
> (propagated-inputs
> (list python-dataclasses python-pytest python-pytz))
When the package is a module, all runtime inputs should be propagated.
I also removed python-requests since it was not being used.
> + (description "This is @code{astral} a Python module which
> calculates times
> + for various positions of the sun: dawn, sunrise, solar noon,
> sunset, dusk,
> +solar elevation, solar azimuth, rahukaalam, and the phases of the
> moon.")
I'd reword it starting with "@code{astral} is a Python module ..."
The indentation is also off. If you're using Emacs you can use one of
its indent commands to fix it.
Could you send a v2 with these changes?
next prev parent reply other threads:[~2022-01-04 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 23:22 [bug#52991] [PATCH] gnu: Add python-astral Disseminate Dissent via Guix-patches via
2022-01-04 3:08 ` Vinicius Monego [this message]
2022-01-04 15:50 ` Disseminate Dissent via Guix-patches via
2022-01-08 22:23 ` bug#52991: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27c76bb8372bf201724f26a79c30ccee9ed0d124.camel@posteo.net \
--to=monego@posteo.net \
--cc=52991@debbugs.gnu.org \
--cc=disseminatedissent@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).