From: Adam Kandur via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 48797@debbugs.gnu.org
Subject: [bug#48797] [PATCH] gnu: Add emacs-vscode-dark-plus.
Date: Thu, 3 Jun 2021 01:28:29 +0200 (CEST) [thread overview]
Message-ID: <MbE2cgj--F-2@tuta.io> (raw)
In-Reply-To: <87im2wgiia.fsf@nicolasgoaziou.fr>
From aea8e982b74608cd55c21ebd6d4cd01a23b50102 Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Thu, 3 Jun 2021 02:24:44 +0300
Subject: [PATCH] gnu: Add emacs-vscode-dark-plus.
* gnu/packages/emacs-xyz.scm (emacs-vscode-dark-plus): New variable.
---
gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 81aec30..e03e962 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -425,6 +425,27 @@ repositories through the
server}. The main advantage compared to @code{vc-hg} is speed.")
(license license:gpl3+)))
+(define-public emacs-vscode-dark-plus
+ (package
+ (name "emacs-vscode-dark-plus")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ianyepan/vscode-dark-plus-emacs-theme")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1vcaqvhdgr91pr7kqskbscs8awm8jp6dkh79h6w36i9ipmc4l4hl"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/ianyepan/vscode-dark-plus-emacs-theme")
+ (synopsis "Emacs port of the default VS Code Dark+ theme")
+ (description
+ "This theme aims to be as identical as possible to the default Dark+
+color scheme used by Visual Studio Code.")
+ (license license:gpl3+)))
+
(define-public emacs-hyperbole
(package
(name "emacs-hyperbole")
--
2.31.1
Jun 2, 2021, 19:43 by mail@nicolasgoaziou.fr:
> Hello,
>
> Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
>
>> Subject: [PATCH] gnu: Add emacs-vscode-dark-plus.
>>
>
> Thank you. Some comments follow.
>
>> + (version "v2.0.0")
>>
>
> The version should be "2.0.0".
>
> The "v" prefix should be appendend ...
>
>> + (uri (git-reference
>> + (url "https://github.com/ianyepan/vscode-dark-plus-emacs-theme")
>> + (commit version)))
>>
>
> ... here with (string-append "v" version)
>
>> + (synopsis "A port of the default VS Code Dark+ theme")
>>
>
> The synopsis cannot start with the article "A". You may want to run guix
> lint to catch this. I suggest the following:
>
> Emacs port of the default VS Code Dark+ theme
>
>> + (description
>> + "An accurate port of the default Visual Studio Code Dark+ theme for Emacs. This theme aims to be as
>> +identical as possible to the default Dark+ color scheme used by Visual Studio Code.")
>>
>
> The description cannot start with the article "An" either. See above.
> Besides, the two sentences have the same meaning. I suggest to drop the
> first one.
>
>> + (license license:gpl3)))
>>
>
> The license is actually gpl3+ if you look at the header of
> "vscode-dark-plus-theme.el".
>
> Also, there seems to be an issue with white spaces.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
next prev parent reply other threads:[~2021-06-02 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 19:00 [bug#48797] [PATCH] gnu: Add emacs-vscode-dark-plus Adam Kandur via Guix-patches via
2021-06-02 19:43 ` Nicolas Goaziou
2021-06-02 23:28 ` Adam Kandur via Guix-patches via [this message]
2021-06-05 13:49 ` bug#48797: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MbE2cgj--F-2@tuta.io \
--to=guix-patches@gnu.org \
--cc=48797@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=rndd@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).