From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CEaPJ0wUuGCuBwEAgWs5BA (envelope-from ) for ; Thu, 03 Jun 2021 01:29:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6KWQIkwUuGCQVgAAB5/wlQ (envelope-from ) for ; Wed, 02 Jun 2021 23:29:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 910B91CE83 for ; Thu, 3 Jun 2021 01:29:15 +0200 (CEST) Received: from localhost ([::1]:52914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loaIU-0001E7-By for larch@yhetil.org; Wed, 02 Jun 2021 19:29:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loaIJ-0001DN-20 for guix-patches@gnu.org; Wed, 02 Jun 2021 19:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loaII-0000cG-RV for guix-patches@gnu.org; Wed, 02 Jun 2021 19:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loaII-00042M-NM for guix-patches@gnu.org; Wed, 02 Jun 2021 19:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48797] [PATCH] gnu: Add emacs-vscode-dark-plus. Resent-From: Adam Kandur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jun 2021 23:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48797 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 48797@debbugs.gnu.org Received: via spool by 48797-submit@debbugs.gnu.org id=B48797.162267652215479 (code B ref 48797); Wed, 02 Jun 2021 23:29:02 +0000 Received: (at 48797) by debbugs.gnu.org; 2 Jun 2021 23:28:42 +0000 Received: from localhost ([127.0.0.1]:41556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loaHt-00041P-8H for submit@debbugs.gnu.org; Wed, 02 Jun 2021 19:28:42 -0400 Received: from w4.tutanota.de ([81.3.6.165]:57816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loaHr-00041A-8Z for 48797@debbugs.gnu.org; Wed, 02 Jun 2021 19:28:35 -0400 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 4B79E10602EC; Wed, 2 Jun 2021 23:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1622676509; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=SjSJXJAbol3sbD/HIMeI1LJ2B490OztcS7MlLInz0CI=; b=IqzC7gIeSllteoYecdp5xtZHQR424ksfGMNYbIvRwlIOENlND+BCUbdp3z3DZzse JZpmVrr0LWmQto91R7AgGgWIj+rNL0jlrL4WsRdSrKtkG+Iu7+DSxQJ/yWRfzz41EVB P3e73u1zt8d02gvc/3fj2CBp36Kh8c5k7eqNnnW65NKWoqlE+WdAT/OyPeHyZ7YX7K0 zL0NwJXNMU/61KYPki05t2bA5WSWPkyjskXCjFvcKCkGO3m4WgV3wkvKMwU4uVmoKWy mkwChsSlO56D1I8U0zE6AUCBhB1XBhkppWMGl5w6zuSPRicsG0tPL9flr7hR7lO+Eu8 lDn32D1qzQ== Date: Thu, 3 Jun 2021 01:28:29 +0200 (CEST) Message-ID: In-Reply-To: <87im2wgiia.fsf@nicolasgoaziou.fr> References: <87im2wgiia.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Adam Kandur X-ACL-Warn: , Adam Kandur via Guix-patches From: Adam Kandur via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622676555; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SjSJXJAbol3sbD/HIMeI1LJ2B490OztcS7MlLInz0CI=; b=qEJkTG3uLEkzS15Xdavq7T6l9xx18HFn0XZa3WqVGv/FLuAOw53vyHJRKFRnqSs1ofiI61 1DHW3momBCqCR8rAW+cYxGWVIYcsShvye51eV/+Q8TleW3WLaPqAURayal+FRsmvKTewxw 2E5361qJkBFEmvgadyyzEePZZO/ckiB9XLWMsTND3n6JPzwwN5WPgFizZb1S+NQAPp7+NW R6l+cVa11PVWngAz/CIA02XeZDJqK9UQR1U8oZwrWWg1LcIHxu/Wm5nYuCUx565o+e7UOw uLQNsKdvLziYNRBCNwMlHLhU5t8jTftSTLZ8bOAKiYNEsVjIKx4NDfHrUM4BKg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622676556; a=rsa-sha256; cv=none; b=s76XykiBobRyl7H1wXu0Jo4Y8djBBQHnc7OSaB0ghzs0pY/UVxLxKhCSDau5gIeRb4II27 yN+nh5zzRJWJOEeG6uf1ufgBPO6EMmcY2il4eqWrcUr8zjzLdTKKDBcvNbYWOim2U+01pN hc0ufssk+6DdFm5251mennIfWFoh8JoPVgPKyV50zMRMpYQE/OviqM3EXbnW+StxIEHzIq MrDCTFslY0ntwa56+Ipu5TxVDeiVsyh0OxPsK8vPYH0uDvTtAIZ3j2kawOhqilrSoOjyl8 9PZsK53xpzM2tugEzOrYZsHfWglRYYAU88Tlcqv6mZ4x2hbky1ru7jwx1CD9Bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tuta.io header.s=s1 header.b=IqzC7gIe; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tuta.io header.s=s1 header.b=IqzC7gIe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 910B91CE83 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: zdPs6f1IO2xZ >From aea8e982b74608cd55c21ebd6d4cd01a23b50102 Mon Sep 17 00:00:00 2001 From: Adam Kandur Date: Thu, 3 Jun 2021 02:24:44 +0300 Subject: [PATCH] gnu: Add emacs-vscode-dark-plus. * gnu/packages/emacs-xyz.scm (emacs-vscode-dark-plus): New variable. --- gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 81aec30..e03e962 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -425,6 +425,27 @@ repositories through the server}.=C2=A0 The main advantage compared to @code{vc-hg} is speed.") =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) +(define-public emacs-vscode-dark-plus +=C2=A0 (package +=C2=A0=C2=A0=C2=A0 (name "emacs-vscode-dark-plus") +=C2=A0=C2=A0=C2=A0 (version "2.0.0") +=C2=A0=C2=A0=C2=A0 (source +=C2=A0=C2=A0=C2=A0=C2=A0 (origin +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (= url "https://github.com/ianyepan/vscode-dark-plus-emacs-theme") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (= commit (string-append "v" version)))) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file-name name versio= n)) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1vcaqvhdgr91pr7kqskbsc= s8awm8jp6dkh79h6w36i9ipmc4l4hl")))) +=C2=A0=C2=A0=C2=A0 (build-system emacs-build-system) +=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/ianyepan/vscode-dark-plu= s-emacs-theme") +=C2=A0=C2=A0=C2=A0 (synopsis "Emacs port of the default VS Code Dark+ them= e") +=C2=A0=C2=A0=C2=A0 (description +=C2=A0=C2=A0=C2=A0=C2=A0 "This theme aims to be as identical as possible t= o the default Dark+ +color scheme used by Visual Studio Code.") +=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) + (define-public emacs-hyperbole =C2=A0=C2=A0 (package =C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-hyperbole") --=20 2.31.1 Jun 2, 2021, 19:43 by mail@nicolasgoaziou.fr: > Hello, > > Adam Kandur via Guix-patches via writes: > >> Subject: [PATCH] gnu: Add emacs-vscode-dark-plus. >> > > Thank you. Some comments follow. > >> +=C2=A0=C2=A0=C2=A0 (version "v2.0.0") >> > > The version should be "2.0.0". > > The "v" prefix should be appendend ... > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (url "https://github.com/ianyepan/vscode-dark-plus-emacs-theme") >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (commit version))) >> > > ... here with (string-append "v" version) > >> +=C2=A0=C2=A0=C2=A0 (synopsis "A port of the default VS Code Dark+ theme= ") >> > > The synopsis cannot start with the article "A". You may want to run guix > lint to catch this. I suggest the following: > > Emacs port of the default VS Code Dark+ theme > >> +=C2=A0=C2=A0=C2=A0 (description >> +=C2=A0=C2=A0=C2=A0=C2=A0 "An accurate port of the default Visual Studio= Code Dark+ theme for Emacs.=C2=A0 This theme aims to be as >> +identical as possible to the default Dark+ color scheme used by Visual = Studio Code.") >> > > The description cannot start with the article "An" either. See above. > Besides, the two sentences have the same meaning. I suggest to drop the > first one. > >> +=C2=A0=C2=A0=C2=A0 (license license:gpl3))) >> > > The license is actually gpl3+ if you look at the header of > "vscode-dark-plus-theme.el". > > Also, there seems to be an issue with white spaces. > > Could you send an updated patch? > > Regards, > --=20 > Nicolas Goaziou >