[bug#42821] [PATCH] gnu: add sbcl-xmls

[bug#42821] [PATCH] gnu: add sbcl-xmls

[Adam Kandur via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]




[-- Attachment #2: 0001-gnu-Add-sbcl-xmls.patch --]
[-- Type: text/x-patch, Size: 1821 bytes --]

From ad2cdcd9fbd463643b38be0aafb4b64e31c9ab09 Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Wed, 12 Aug 2020 09:41:59 +0300
Subject: [PATCH] gnu: Add sbcl-xmls.

* gnu/packages/lisp-xyz.scm (sbcl-xmls): New variable.
---
 gnu/packages/lisp-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index b8216b0..7c0be15 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -13509,3 +13509,33 @@ for an example.")
 
 (define-public ecl-hu.dwim.defclass-star
   (sbcl-package->ecl-package sbcl-hu.dwim.defclass-star))
+
+(define-public sbcl-xmls
+  (let ((commit "18546f0850b1338e03997ffd1696add1cb1800d1")
+	(revision "1"))
+    (package
+      (name "sbcl-xmls")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/rpgoldman/xmls")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1lmvfml2ldbb1wkhm25jqqk2bhwsz52hhcgljbnzj1xr8xhc3anp"))))
+      (inputs
+       `(("fiveam" ,sbcl-fiveam)))
+      (build-system asdf-build-system/sbcl)
+      (home-page "https://github.com/rpgoldman/xmls")
+      (synopsis "Xmls is a small, simple, non-validating xml parser for Common Lisp.")
+      (description "Xmls designed to be a self-contained, easily embedded parser that recognizes a useful subset of the XML spec.
+It provides a simple mapping from xml to lisp structures or s-expressions and back.")
+      (license license:bsd-2))))
+
+(define-public cl-xmls
+  (sbcl-package->cl-source-package sbcl-xmls))
+
+(define-public ecl-xmls
+  (sbcl-package->ecl-package sbcl-xmls))
-- 
2.28.0

[bug#42821] [PATCH] gnu: add sbcl-xmls

[Leo Famulari]

> From ad2cdcd9fbd463643b38be0aafb4b64e31c9ab09 Mon Sep 17 00:00:00 2001
> From: Adam Kandur <rndd@tuta.io>
> Date: Wed, 12 Aug 2020 09:41:59 +0300
> Subject: [PATCH] gnu: Add sbcl-xmls.
> 
> * gnu/packages/lisp-xyz.scm (sbcl-xmls): New variable.

Thanks! Please make sure the commit message mentions all the new
variables.

> +      (inputs
> +       `(("fiveam" ,sbcl-fiveam)))

I noticed that the built package does not keep a reference to
sbcl-fiveam. Is that expect for SBCL packages? Is it just for
build-time?

> +      (license license:bsd-2))))

The COPYING file contains a 3-clause BSD license.

Can you look into the fiveam issue and submit a revised patch?

bug#42821: [PATCH] gnu: add sbcl-xmls

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]


This was fixed by commit 7722c367bc007ca979bc7cb16e135c7ac0b864ed.
Closing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]