unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Petkov <ivanppetkov@gmail.com>
To: 35813@debbugs.gnu.org
Cc: Karl Meakin <karl.w.f.meakin@gmail.com>,
	Karl Meakin <Karlwfmeakin@gmail.com>
Subject: [bug#35813] [PATCH] import: crate: add recursive option
Date: Sat, 25 May 2019 12:38:08 -0700	[thread overview]
Message-ID: <F514F3C2-FA56-4958-916B-488EBF898E15@gmail.com> (raw)
In-Reply-To: <87woifuadk.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

Hi Karl,

Thanks for the patch, overall the implementation looks good to me!

> On May 24, 2019, at 8:42 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> 
> would it be possible to augment ‘tests/crate.scm’ with tests for
> recursive imports?  That would be great.

I second Ludo’s comment here, having some tests around this would be great!

Also, have you had a chance to test this by importing a Rust application?
I tried to import hexyl (which has a small dependency closure compared to other
applications), but the final result had some missing crate input definitions
(e.g. Maybe a crate depends on rust-foo, but rust-foo wasn't defined in the
output either). Maybe I did something wrong, but it would be good to confirm!

Also, don't worry about actually trying to build any imported packages as of
yet, you might hit a cycle issue between proc-macro2 and quote. I've got a
patch open[0] for fixing the cargo-build-system to handle this!

--Ivan

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35318 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35318>


[-- Attachment #2: Type: text/html, Size: 1966 bytes --]

  reply	other threads:[~2019-05-25 19:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 18:23 [bug#35813] [PATCH] import: crate: add recursive option Karl Meakin
2019-05-24 15:42 ` Ludovic Courtès
2019-05-25 19:38   ` Ivan Petkov [this message]
2019-07-20 18:30 ` [bug#35813] Brian Leung
2019-07-20 21:43   ` [bug#35813] Ivan Petkov
2019-08-05 17:50 ` [bug#35813] [PATCH] Add crate-recursive-import Brian Leung
2019-08-06  3:42   ` Brian Leung
2019-08-06 16:03     ` Brian Leung
2019-08-08 10:39       ` Efraim Flashner
2019-09-07 21:49         ` Brian Leung
2019-09-08  7:57           ` Efraim Flashner
2019-10-13  7:42             ` bug#35813: " Brian Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F514F3C2-FA56-4958-916B-488EBF898E15@gmail.com \
    --to=ivanppetkov@gmail.com \
    --cc=35813@debbugs.gnu.org \
    --cc=Karlwfmeakin@gmail.com \
    --cc=karl.w.f.meakin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).