unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Leung <bkleung89@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 35813-done@debbugs.gnu.org, Ivan Petkov <ivanppetkov@gmail.com>
Subject: bug#35813: [PATCH] Add crate-recursive-import.
Date: Sun, 13 Oct 2019 00:42:22 -0700	[thread overview]
Message-ID: <CAAc=MEx=2ja4qba-dms=7L3uXX2X-EcMyECf6_Cs0Zq9jHfrWA@mail.gmail.com> (raw)
In-Reply-To: <20190908075730.GA977@E5400>

[-- Attachment #1: Type: text/plain, Size: 2401 bytes --]

Closing this since someone else already merged their own crate recursive
importer.

On Sun, Sep 8, 2019 at 12:57 AM Efraim Flashner <efraim@flashner.co.il>
wrote:

> As a simple test I ran 'guix import crate encoding -r' and it gave me
> the 6 packages I expected. 'guix import crate winapi -r' only gave me
> rust-winapi, as the dependent crates are already packaged. When I tried
> 'guix import crate rand -r' it found the updated version and started
> importing all the new dependencies also.
>
> It looks good. I'm tempted to leave it running with 'guix import crate
> serde -r' just to see if we're ever going to make it there.
>
> I see that it imports A then B then C then D, and prints out D then C
> then B then A. For the one I tested with is still rust-encoding. I'll
> try my hand at ascii art:
>
>                             encoding
>                                 |
>   -------------------------------------------------------
>   |         |               |           |               |
> japanese  korean      simpchinese    singlebyte     tradchinese
>   |         |               |           |               |
>   -------------------------------------------------------
>                         |
>                  encoding-tests
>
> import went encoding, japanese, tests, korean, simpchinese, singlebyte,
> tradchinese
>
> I think the only thing I would wish for would be to do tests, then the
> languages and then encoding (best for upstreaming one at a time), or to
> do them alphabetically (plop them in alphabetically all at once). This
> I'm happy to live without I think.
>
> The other thing was I ran 'guix import crate security-framework -r' and
> after ~40 crates it crashed on me with:
>     web/http.scm:1186:15: In procedure read-response-line:
>     Bad Read-Header-Line header: #<eof>
> and I would prefer to have the ~40 crates it did grab first to be
> printed out and not lost. Between these two I would like most to not
> lose the imported crates than worrying over the printed order.
>
> Great job! From what I've tested I think it's ready as-is and any
> changes would just be gravy.
>
>
> --
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
>

[-- Attachment #2: Type: text/html, Size: 3050 bytes --]

      reply	other threads:[~2019-10-13  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 18:23 [bug#35813] [PATCH] import: crate: add recursive option Karl Meakin
2019-05-24 15:42 ` Ludovic Courtès
2019-05-25 19:38   ` Ivan Petkov
2019-07-20 18:30 ` [bug#35813] Brian Leung
2019-07-20 21:43   ` [bug#35813] Ivan Petkov
2019-08-05 17:50 ` [bug#35813] [PATCH] Add crate-recursive-import Brian Leung
2019-08-06  3:42   ` Brian Leung
2019-08-06 16:03     ` Brian Leung
2019-08-08 10:39       ` Efraim Flashner
2019-09-07 21:49         ` Brian Leung
2019-09-08  7:57           ` Efraim Flashner
2019-10-13  7:42             ` Brian Leung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAc=MEx=2ja4qba-dms=7L3uXX2X-EcMyECf6_Cs0Zq9jHfrWA@mail.gmail.com' \
    --to=bkleung89@gmail.com \
    --cc=35813-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=ivanppetkov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).