From: Julien Lepiller <julien@lepiller.eu>
To: 47804@debbugs.gnu.org, ludo@gnu.org, public@yoctocell.xyz
Cc: 47804-done@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names.
Date: Fri, 16 Apr 2021 17:42:30 -0400 [thread overview]
Message-ID: <E609DF3C-68B3-4A32-B103-5C38F64834E0@lepiller.eu> (raw)
In-Reply-To: <87eefa2bmw.fsf_-_@gnu.org>
Le 16 avril 2021 16:54:47 GMT-04:00, "Ludovic Courtès" <ludo@gnu.org> a écrit :
>Hi,
>
>Xinglu Chen <public@yoctocell.xyz> skribis:
>
>> As per section '16.4.2 Package Naming' in the manual, use hyphens
>> instead of underscores in package names.
>>
>> * guix/lint.scm (check-name): Check whether the package name contains
>> underscores.
>> * tests/lint.scm ("name: use underscore in package name"): New test.
>
>Applied with the minor change below, which avoids regexps
>(‘string-match’ performs regexp matches, which is overkill here).
>
>Thank you and thanks Maxime for the review!
>
>Ludo’.
Hm… unless I'm mistaken, this patch adds a string to the guix domain, which is part of the string freeze.
The guix-packages is not part of the string freeze, that is to say synopsis and description of packages, only.
prev parent reply other threads:[~2021-04-16 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 16:00 [bug#47804] [PATCH] lint: Warn about underscores in package names Xinglu Chen
2021-04-15 16:19 ` Maxime Devos
2021-04-15 18:15 ` Xinglu Chen
2021-04-16 10:19 ` Maxime Devos
2021-04-15 18:31 ` [bug#47804] [PATCH v2] " Xinglu Chen
2021-04-16 20:54 ` bug#47804: [PATCH] " Ludovic Courtès
2021-04-16 21:42 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E609DF3C-68B3-4A32-B103-5C38F64834E0@lepiller.eu \
--to=julien@lepiller.eu \
--cc=47804-done@debbugs.gnu.org \
--cc=47804@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maximedevos@telenet.be \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).