From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aIa4F7AMemALLAEAgWs5BA (envelope-from ) for ; Sat, 17 Apr 2021 00:16:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MMOBErAMemCVMAAA1q6Kng (envelope-from ) for ; Fri, 16 Apr 2021 22:16:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1391120C9E for ; Sat, 17 Apr 2021 00:16:16 +0200 (CEST) Received: from localhost ([::1]:36468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXWl5-0004hz-6E for larch@yhetil.org; Fri, 16 Apr 2021 18:16:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXWEx-0005Oz-5d for guix-patches@gnu.org; Fri, 16 Apr 2021 17:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXWEw-00061q-SP for guix-patches@gnu.org; Fri, 16 Apr 2021 17:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXWEv-0005Xy-PO for guix-patches@gnu.org; Fri, 16 Apr 2021 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Apr 2021 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47804@debbugs.gnu.org, ludo@gnu.org, public@yoctocell.xyz Cc: 47804-done@debbugs.gnu.org, Maxime Devos X-Debbugs-Original-To: guix-patches@gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Xinglu Chen Received: via spool by submit@debbugs.gnu.org id=B.161860937721311 (code B ref -1); Fri, 16 Apr 2021 21:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Apr 2021 21:42:57 +0000 Received: from localhost ([127.0.0.1]:41879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXWEq-0005Xe-Nv for submit@debbugs.gnu.org; Fri, 16 Apr 2021 17:42:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:50818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXWEl-0005XT-Gs for submit@debbugs.gnu.org; Fri, 16 Apr 2021 17:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXWEk-000524-GM for guix-patches@gnu.org; Fri, 16 Apr 2021 17:42:51 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:51892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXWEi-0005rE-1u; Fri, 16 Apr 2021 17:42:50 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 62371430; Fri, 16 Apr 2021 21:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=S94FNkjoAoF45Rz21Kn8fxL4IwrT2lxyOarjvL9ZXnA=; b=IRpBAcC WRiuxijHiV1OfROohwhzAzLJJOE7t4DFysxm/x2RQ23JJT5bbszg1SrtbdIxUlei om+ADXd8nIbW08K16dK2xklHx4sYKWxDwEEEbayWpma7lcL3amksIfQgixONFgEI WA7FlmnRx8DNWw0bV8TXKAxXZaRc5PoQ5pTfA10uaL57g2m5DsBe4hh/BZiH4Rkq MDXWWFwDp6Uqj0BlfcDIpG2FedVaWTqFCpj8ef+48birTXX/XSCSXibWAxYuuigZ Ls9gr/VgTWdJCbQmPhX8o/DcUC/xKyw2IfZ2S+f+OiR6vVZwFHMC3jv2IxoUgrx9 TBItdqyu0kew6Kw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 952ea788 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 16 Apr 2021 21:42:40 +0000 (UTC) Date: Fri, 16 Apr 2021 17:42:30 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <87eefa2bmw.fsf_-_@gnu.org> References: <94d0b8cb2322ed634442c0ebb79589e5dc05e526.1618511382.git.public@yoctocell.xyz> <87eefa2bmw.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Julien Lepiller Message-ID: Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618611376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=S94FNkjoAoF45Rz21Kn8fxL4IwrT2lxyOarjvL9ZXnA=; b=gKWgUFd+dato2BnIoUhDI0dtCkxpOqu9Mu8SEUH4omxfg3VQWuDygGwhjaxqEA+C331Zst ROC3YclN3lJA/Fn+ljr1A/Kis9cFeU5VAMXmAseTJqrXyhsX9z0778WtoZkdGYb10IN612 IuQWaSrsGZ9WYj7IKmey/Vhbo/5B3vNBIAxo4KwjDE5OikidhT0bbe5aIkLp5/0il/NUSn HtiX905H3xyGLQUYwqoOS89tqwjZxuA+vDp6ZMCh+hIisBabPi7twgaBdj5Av+tjBThffh LeTmlbFA4h4fDmQMl8njyw/G1BeGRsuXldj9SZriOQBOTKSDKGsS2BOsl2NpDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618611376; a=rsa-sha256; cv=none; b=qx5fgb1qgw1hmJmFYgiIv4dNHPbK+zpa5R+gWWF2joZdCqpLIhUu7MrV98LMEechWey7J7 dUXgl53dQzhhBjvaJWHOCyQEZwjdfSGjmNzIgSYxO73og+m0SKxrpg47al5PZxR2U0l5Zm s4dlDXzyFaNLPjyiAsvsfi43IwGnMSXsdqSu3erh6OS3SYDcA0b3Pe+ol0id8qwo06jY7m jeT8ciUcpIekvo7kiyz5jLdgpHDjBSiGNo4ZKWdlRACcdreoYAXyzCcoMgdekftBvOgA3e abMQn4wyS+GS8o6PzorDrhCqInsFwXvZCW3/B4MRzYswaVQVk6k4awVb77us9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="IRpBAcC "; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="IRpBAcC "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1391120C9E X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: xL2SPyB/+FIm Le 16 avril 2021 16:54:47 GMT-04:00, "Ludovic Court=C3=A8s" a =C3=A9crit : >Hi, > >Xinglu Chen skribis: > >> As per section '16=2E4=2E2 Package Naming' in the manual, use hyphens >> instead of underscores in package names=2E >> >> * guix/lint=2Escm (check-name): Check whether the package name contains >> underscores=2E >> * tests/lint=2Escm ("name: use underscore in package name"): New test= =2E > >Applied with the minor change below, which avoids regexps >(=E2=80=98string-match=E2=80=99 performs regexp matches, which is overkil= l here)=2E > >Thank you and thanks Maxime for the review! > >Ludo=E2=80=99=2E Hm=E2=80=A6 unless I'm mistaken, this patch adds a string to the guix doma= in, which is part of the string freeze=2E The guix-packages is not part of the string freeze, that is to say synopsi= s and description of packages, only=2E