unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Tomasz Jeneralczyk" <tj@schwi.pl>, <56041@debbugs.gnu.org>
Subject: [bug#56041] [PATCH] gnu: Add vkmark.
Date: Fri, 17 Jun 2022 20:10:15 +0100	[thread overview]
Message-ID: <CKSNAO3LQ6KG.1WY5SU8ZWD8LB@guix-aspire> (raw)
In-Reply-To: <b9edc90fb6081f2ea0495b9c22527134@schwi.pl>

Hi! :D This package seems good to me: passes all lints, builds, and
style looks okay.

On Fri Jun 17, 2022 at 4:24 PM BST, Tomasz Jeneralczyk wrote:
> +(define-public vkmark
> +  (let ((commit "d872846e2e7c47010c11227eb713d00ccfdd35c6")
> +        (revision "1"))

I think it's common to include an explanation of why tags aren't used :)

> +                (file-name (git-file-name name version))
> +                (uri (git-reference
> +                      (url "https://github.com/vkmark/vkmark")
> +                      (commit commit)))

Nitpick: file-name usually comes after uri in most of the packages I've
seen. Maybe run guix style, if you haven't already.

> +      (native-inputs (list pkg-config cmake))

Why include cmake? It seems to compile without it :)

> +      (synopsis "Benchmark for Vulkan")

Maybe expand this to "Extensible benchmarking suite for Vulkan" or
something? I'd say this synopsis is a bit too short.




  reply	other threads:[~2022-06-17 19:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 15:24 [bug#56041] [PATCH] gnu: Add vkmark Tomasz Jeneralczyk
2022-06-17 19:10 ` ( via Guix-patches via [this message]
2022-06-17 19:59   ` ( via Guix-patches via
2022-06-18  8:13 ` [bug#56041] Fwd: " ( via Guix-patches via
2022-06-18  8:13 ` ( via Guix-patches via
2022-06-18 23:01 ` [bug#56041] [PATCH v2] " Tomasz Jeneralczyk
2022-06-19  8:07   ` ( via Guix-patches via
2022-06-19  9:07   ` Maxime Devos
2022-06-19  9:08   ` Maxime Devos
2022-06-19 15:46 ` [bug#56041] [PATCH v3] " Tomasz Jeneralczyk
2022-06-27 16:02 ` [bug#56041] [PATCH v4] " Tomasz Jeneralczyk
2022-11-06  9:40   ` ( via Guix-patches via
2022-11-07 15:31     ` Tomasz Jeneralczyk
2022-11-07 17:07       ` ( via Guix-patches via
2022-11-07 16:01 ` [bug#56041] [PATCH v5] " Tomasz Jeneralczyk
2022-11-07 17:09   ` ( via Guix-patches via
2023-01-08 15:11   ` bug#56041: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CKSNAO3LQ6KG.1WY5SU8ZWD8LB@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=56041@debbugs.gnu.org \
    --cc=paren@disroot.org \
    --cc=tj@schwi.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).