From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wFQnGdLRrGL+HAAAbAwnHQ (envelope-from ) for ; Fri, 17 Jun 2022 21:11:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qAUmGNLRrGJW3wAAG6o9tA (envelope-from ) for ; Fri, 17 Jun 2022 21:11:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0A8210EA6 for ; Fri, 17 Jun 2022 21:11:13 +0200 (CEST) Received: from localhost ([::1]:47486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2HNA-0001dW-F2 for larch@yhetil.org; Fri, 17 Jun 2022 15:11:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2HN0-0001dM-Us for guix-patches@gnu.org; Fri, 17 Jun 2022 15:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2HN0-0002OR-Mr for guix-patches@gnu.org; Fri, 17 Jun 2022 15:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2HN0-0002Ov-EP for guix-patches@gnu.org; Fri, 17 Jun 2022 15:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56041] [PATCH] gnu: Add vkmark. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Jun 2022 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56041 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Tomasz Jeneralczyk" , <56041@debbugs.gnu.org> Received: via spool by 56041-submit@debbugs.gnu.org id=B56041.16554930219179 (code B ref 56041); Fri, 17 Jun 2022 19:11:02 +0000 Received: (at 56041) by debbugs.gnu.org; 17 Jun 2022 19:10:21 +0000 Received: from localhost ([127.0.0.1]:46975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2HMK-0002Ny-RX for submit@debbugs.gnu.org; Fri, 17 Jun 2022 15:10:21 -0400 Received: from knopi.disroot.org ([178.21.23.139]:48132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2HMI-0002Nn-IR for 56041@debbugs.gnu.org; Fri, 17 Jun 2022 15:10:19 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 3C61E445B0; Fri, 17 Jun 2022 21:10:17 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CAq6FcGwR7Vo; Fri, 17 Jun 2022 21:10:16 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1655493015; bh=z4pUmlAW9E4Tl6inZ9YQ0qwj2JiWb6Vc89qzCVeagUs=; h=Date:From:To:Subject:References:In-Reply-To; b=QDGuTtTky1XybFQZM5GUmJkLWl6vIOH+TrwPZMmVIiQJ5s7LvUjHVCQjiZHeAEw1Y OchyNSJK/x0N8n+1DtHBwQ2W7o8s/5KH5wjZp82jg9oKdMZ+lvit/Q3D1XgKw7fzMh JOA1JFQxpgs++/WrYkj9DUwpaYqNeTVz0J9PgQXnwVsjeXoVjHr8sgDlA+w1kQLtMh uLKWXDWMqJAvT4T/O6sW5uvIt6bjC+aOYzozYN6hLX1yrrOR9GW4u5MyfskO6/ByKv jF6cDO/YCqzfkQAcn15dUKhxcGGeJfWVdZxzvqdMSdUAbvUtVwJm4qfIb/FFveh7Q1 QDQwB6VYL/TMA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jun 2022 20:10:15 +0100 Message-Id: References: In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655493074; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FiTUhYMhkU4o9fthzxMwJdfQbNVaKxzhw+TStiOGZ+4=; b=VSWev8aF3EJvOFCnXZUTBgOK+yMJ1rzgOaVV9f4qVlO1SPLLqPDgztyFJTTtbm0tdRX4+M Mby9skDzh7SdARvm6MQxOZFjmvyTWo2RiXsTLZsSJ+lHC5wvfLgpAHHjtEiZ6/MJMPI1bI FG3aAc/XHmdT/VetLVn8R/n3/xD9P+dFFt0Q+n91BI+rgm4n7qBNlGxNXc4y0O4HZL/7rZ qWtvlaOe6bYirS3/9WUfKTtTqfSg484w5xtmhSnfQVxmVnOJ0d52pl+36ud2ptw1RcnwsS tUAMADZLmA+ay0e0FbFw2yG5RGQBEpD+279VVpMFXKRU43qTbw1tduyJCabfwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655493074; a=rsa-sha256; cv=none; b=dXSFVmBwOq6ECNiqy6UTu/zG2RLvbEFddPRCT9EiX7xa3nDEYchjuQDesnQfRrR22X2HwS whsgnhnYNUAZT8uK+hpeR6YawoO0J6gvHaeSY4vd3E1tEJfoESRVOvidpr8hUNkjyL9Kai V785ocnnHA8gJy3j77dzgYP0GTg5luYtIQRsHGPckdsXojbDSKhnhYPpEnNUg+M6mb8hXj Y8IdV6i7/VSbiUxrEzSoM70FRobVAaBAubWFLd8GgTmlNJqI+mPwW4KOUL4bN5RedjX/1g YbmMffDEpeLRQs7tDbYOpTp94AqMuQcZm5joOAjwqGADBQJQUeo+vydeen3hpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=QDGuTtTk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=QDGuTtTk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B0A8210EA6 X-Spam-Score: -2.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: URaEGe8Ct+xk Hi! :D This package seems good to me: passes all lints, builds, and style looks okay. On Fri Jun 17, 2022 at 4:24 PM BST, Tomasz Jeneralczyk wrote: > +(define-public vkmark > + (let ((commit "d872846e2e7c47010c11227eb713d00ccfdd35c6") > + (revision "1")) I think it's common to include an explanation of why tags aren't used :) > + (file-name (git-file-name name version)) > + (uri (git-reference > + (url "https://github.com/vkmark/vkmark") > + (commit commit))) Nitpick: file-name usually comes after uri in most of the packages I've seen. Maybe run guix style, if you haven't already. > + (native-inputs (list pkg-config cmake)) Why include cmake? It seems to compile without it :) > + (synopsis "Benchmark for Vulkan") Maybe expand this to "Extensible benchmarking suite for Vulkan" or something? I'd say this synopsis is a bit too short.