From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 46234@debbugs.gnu.org
Subject: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Fri, 18 Jun 2021 19:29:38 +0000 [thread overview]
Message-ID: <CAO+9K5q4byCp4vSe7TR603SDN-_FEJwAJ2eX4o5eREdkBBaaAQ@mail.gmail.com> (raw)
In-Reply-To: <87y2b75j4s.fsf@yoctocell.xyz>
[-- Attachment #1: Type: text/plain, Size: 2437 bytes --]
Hi Xinglu,
I've reviewed your comments and updated the patch, thanks for your time!
On Fri, 18 Jun 2021 at 14:42, Xinglu Chen <public@yoctocell.xyz> wrote:
>
> On Mon, Feb 01 2021, Sharlatan Hellseher wrote:
>
> > +(define-public go-gopkg-in-yaml-v3
> > + (package
> > + (name "go-gopkg-in-yaml-v3")
> > + (version "3")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "https://gopkg.in/yaml.v3.git")
> > + (commit (string-append "v" version))))
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> > + (build-system go-build-system)
> > + (arguments
> > + '(#:import-path "gopkg.in/yaml.v3"))
> > + (native-inputs
> > + `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> > + (home-page "https://gopkg.in/yaml.v2")
> ^^
> Shouldn’t this be “https://gopkg.in/yaml.v3”?
>
> > + (synopsis "YAML reader and writer for the Go language")
> > + (description
> > + "This package provides a Go library for encode and decode YAML
> > +values.
> > +
> > +v3 specification difference:
> > +@itemize
> > +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> > +being decoded into a typed bool value. Otherwise they behave as a string.
> > +Booleans in YAML 1.2 are true/false only.
> > +
> > +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> > +specified in YAML 1.2, because most parsers still use the old format. Octals in
> > +the 0o777 format are supported though, so new files work.
> > +
> > +@item Does not support base-60 floats. These are gone from YAML 1.2, and were
> > +actually never supported by this package as it's clearly a poor choice.
> > +@end itemize\n")
> > +
> > +@end itemize\n")
>
> Duplicate lines/syntax error. I don’t think \n is needed either.
>
> Otherwise, LGTM.
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
[-- Attachment #2: 0001-gnu-Add-gopkg.in-yaml.v3.patch --]
[-- Type: text/x-patch, Size: 2531 bytes --]
From 55ccab7fbbd5a1610ce630f17e79db8bdc6b4d79 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Fri, 18 Jun 2021 20:27:27 +0100
Subject: [PATCH] gnu: Add gopkg.in/yaml.v3
* gnu/packages/golang.scm (go-gopkg-in-yml-v3): New variable
---
gnu/packages/golang.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8c3c81ceda..19a70c7a82 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -25,6 +25,7 @@
;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
;;; Copyright © 2021 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus@mgail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2413,6 +2414,45 @@ which satisfies the cron expression.")
values.")
(license license:asl2.0)))
+(define-public go-gopkg-in-yaml-v3
+ (package
+ (name "go-gopkg-in-yaml-v3")
+ (version "3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gopkg.in/yaml.v3.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "gopkg.in/yaml.v3"))
+ (native-inputs
+ `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
+ (home-page "https://gopkg.in/yaml.v3")
+ (synopsis "YAML reader and writer for the Go language")
+ (description
+ "This package provides a Go library for encode and decode YAML
+values.
+
+v3 specification difference:
+@itemize
+@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
+being decoded into a typed bool value. Otherwise they behave as a string.
+Booleans in YAML 1.2 are true/false only.
+
+@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
+specified in YAML 1.2, because most parsers still use the old format. Octals in
+the 0o777 format are supported though, so new files work.
+
+@item Does not support base-60 floats. These are gone from YAML 1.2, and were
+actually never supported by this package as it's clearly a poor choice.
+@end itemize")
+ (license license:asl2.0)))
+
(define-public go-github-com-mattn-go-isatty
(package
(name "go-github-com-mattn-go-isatty")
--
2.32.0
next prev parent reply other threads:[~2021-06-18 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 12:46 [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Sharlatan Hellseher
[not found] ` <handler.46234.B.161218363110237.ack@debbugs.gnu.org>
2021-06-13 11:14 ` [bug#46234] Acknowledgement ([PATCH] Add new gopkg.in/yaml.v3) Sharlatan Hellseher
2021-06-18 14:42 ` [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Xinglu Chen
2021-06-18 19:29 ` Sharlatan Hellseher [this message]
2021-06-19 8:31 ` Xinglu Chen
2021-06-22 8:53 ` bug#46234: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO+9K5q4byCp4vSe7TR603SDN-_FEJwAJ2eX4o5eREdkBBaaAQ@mail.gmail.com \
--to=sharlatanus@gmail.com \
--cc=46234@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).