From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNhxF9H2zGB0pwAAgWs5BA (envelope-from ) for ; Fri, 18 Jun 2021 21:41:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OOhEE9H2zGCIaAAAB5/wlQ (envelope-from ) for ; Fri, 18 Jun 2021 19:41:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D107148A1 for ; Fri, 18 Jun 2021 21:41:04 +0200 (CEST) Received: from localhost ([::1]:34610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luKMR-0000BA-4s for larch@yhetil.org; Fri, 18 Jun 2021 15:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luKCk-0002wp-VI for guix-patches@gnu.org; Fri, 18 Jun 2021 15:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luKCk-0002DY-Ma for guix-patches@gnu.org; Fri, 18 Jun 2021 15:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luKCk-0001va-E0 for guix-patches@gnu.org; Fri, 18 Jun 2021 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3 Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Jun 2021 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46234 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 46234@debbugs.gnu.org Received: via spool by 46234-submit@debbugs.gnu.org id=B46234.16240446057271 (code B ref 46234); Fri, 18 Jun 2021 19:31:02 +0000 Received: (at 46234) by debbugs.gnu.org; 18 Jun 2021 19:30:05 +0000 Received: from localhost ([127.0.0.1]:58257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luKBh-0001sO-LY for submit@debbugs.gnu.org; Fri, 18 Jun 2021 15:30:05 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:46820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luKBf-0001s8-1T for 46234@debbugs.gnu.org; Fri, 18 Jun 2021 15:29:55 -0400 Received: by mail-wm1-f43.google.com with SMTP id h22-20020a05600c3516b02901a826f84095so6348011wmq.5 for <46234@debbugs.gnu.org>; Fri, 18 Jun 2021 12:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2xYHFOV3AUB1m9TjpiwhGwtbihQ7J1wuHnXLadjjgEo=; b=ic0OYXQAghInQnbWVkIhnCvYsQMwQgBsbpqrRKbzG4sg1KSV6E2DyYrtjTCtImVMQp fhaw0Y4+/bKDm6LNcnSpiILd1iCJc0gms7DkPedFP9WMuMa69TxZG/V7TKwMsn8qTMlF jWUgkbXNDBUSEKlpA7BJgbqSjqujjBw6fP9FwrtbVu2xQC2cry57uu3nK8qJvN4g14hN yBiWwXgraIMtYdZHWSNCQTvVnPfvIx02jm8NIpBYseQakAcFk+fnVCX0dkDJWmNkpwpY tz6sXpNLA2zudGfpf+p8c1W3NShe9dwvP9zvIkidyOwcDr4OSqMRZokW+J9lcQyhN38o w14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2xYHFOV3AUB1m9TjpiwhGwtbihQ7J1wuHnXLadjjgEo=; b=sEtojgQi42hWlUzOzRtx4AZGKuYVFzgkZhvfx2iJ1GxxQCctqspJHdhX+nGHcSpal+ 2houJOV9C0ty6Be61LOO2fnWysErE6VQfPsNjSriRS32zR62dDlP+bFgw4gPnEeskg4r 7ZX1PIPxW9JDCg+Vht3AcaXJ5a9ViedZR1F7xjzSOdVJbCxl1ycxpVLuG6SulexGkwHQ 3ZaLmUe7s3HXqGX2Ae3FlI66q3bv0fkmxD8iQS4QgOghOp2XZegTRwIcAkyxNU7EwPzQ DUI73Jv2ONzKRQ1vF6Xv71jlbR9eYSJ1r7OuRn08e4aiVcr26Sdb5MBG3KfudT6z88yg P/8A== X-Gm-Message-State: AOAM5329Fs423PU6oQjSKLLNZBWLjI0OQJcMy9KH6UGrR6fE6QzPq4V2 FSE1uZ8fbmQLscvKX4PiXleXK13LoDDP+XkHWcAczF5X X-Google-Smtp-Source: ABdhPJzVup/zfI6Bkhl48HTy6awltPeaDtWAVZ/6V7oo0DotFzeApRZAtLyR5ue+/RwKFHTBx1K0505yM2Kx0RHiL8U= X-Received: by 2002:a7b:c446:: with SMTP id l6mr11835385wmi.171.1624044588885; Fri, 18 Jun 2021 12:29:48 -0700 (PDT) MIME-Version: 1.0 References: <87y2b75j4s.fsf@yoctocell.xyz> In-Reply-To: <87y2b75j4s.fsf@yoctocell.xyz> From: Sharlatan Hellseher Date: Fri, 18 Jun 2021 19:29:38 +0000 Message-ID: Content-Type: multipart/mixed; boundary="000000000000d20d4805c50f5886" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624045265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2xYHFOV3AUB1m9TjpiwhGwtbihQ7J1wuHnXLadjjgEo=; b=LvJwDAZrw4WJdrwfYCVYmKIVyfasuJAYGZWQXElvDOVcZvbTHi7NxMstQVB/eyOdtXQhSV eBJU42XH7tc95FXiWm5BJd9hJHXVZgoiM5//6HJpH8opXws/wT2P6fZVSJBWJuGxLOhZYp lpe3pLrnmAiRl7rYTA7lmn1ekrFis48AzZ/H5imCpUQiueTN4ny1JI1nBPNZ/w8yQBa59x iWFnQCMbRfkOli/PqrTOrtpesBwySaYvX4RL0sy2HQ/8zlDTYDa/NylMUEmA+ezuJLms/m a1udeUJqiPB/LY4lMJTBRZHD2NZxhNiwYxYAp/OtccfW30BLp2TayQPyTeYtPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624045265; a=rsa-sha256; cv=none; b=OHKS6g+17tpjkIW/pfPJajseSC/rblA1Ky/2X08KC/ak7w7xDsFn/e6UrMGw+qoMTQc4mD edfiirVOllKbsiE4Tvs6xDQyTYGvgAeCShD7gIA0V4NcNWraBrlXizy8K4vt5aV4BK6ec1 TIv1QbHA1Wiz+Dzk3e8yIRlO4fxGYmxMsPiBkx/Qlj8BiF7p+vSdvqk99dk0iXaeO6Bsu1 WORk2dXCVlwGX3AM2Jbo8Rnu6fl3eIdj3KVhpK0chYmzU9qnUYE5BfnpyjQf6VcHtPT4MN Jt+opVLgpRVroqEZ9eRZYS4lRNQHYqyA4LGUmBrfxiQB8/x1r7IffMBsk1RSiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ic0OYXQA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ic0OYXQA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9D107148A1 X-Spam-Score: 0.28 X-Migadu-Scanner: scn1.migadu.com X-TUID: sTLLDI82hGNa --000000000000d20d4805c50f5886 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Xinglu, I've reviewed your comments and updated the patch, thanks for your time! On Fri, 18 Jun 2021 at 14:42, Xinglu Chen wrote: > > On Mon, Feb 01 2021, Sharlatan Hellseher wrote: > > > +(define-public go-gopkg-in-yaml-v3 > > + (package > > + (name "go-gopkg-in-yaml-v3") > > + (version "3") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://gopkg.in/yaml.v3.git") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g= ")))) > > + (build-system go-build-system) > > + (arguments > > + '(#:import-path "gopkg.in/yaml.v3")) > > + (native-inputs > > + `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1))) > > + (home-page "https://gopkg.in/yaml.v2") > ^^ > Shouldn=E2=80=99t this be =E2=80=9Chttps://gopkg.in/yaml.v3=E2=80=9D? > > > + (synopsis "YAML reader and writer for the Go language") > > + (description > > + "This package provides a Go library for encode and decode YAML > > +values. > > + > > +v3 specification difference: > > +@itemize > > +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they ar= e > > +being decoded into a typed bool value. Otherwise they behave as a str= ing. > > +Booleans in YAML 1.2 are true/false only. > > + > > +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777= as > > +specified in YAML 1.2, because most parsers still use the old format. = Octals in > > +the 0o777 format are supported though, so new files work. > > + > > +@item Does not support base-60 floats. These are gone from YAML 1.2, = and were > > +actually never supported by this package as it's clearly a poor choice= . > > +@end itemize\n") > > + > > +@end itemize\n") > > Duplicate lines/syntax error. I don=E2=80=99t think \n is needed either. > > Otherwise, LGTM. --=20 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8. --000000000000d20d4805c50f5886 Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-Add-gopkg.in-yaml.v3.patch" Content-Disposition: attachment; filename="0001-gnu-Add-gopkg.in-yaml.v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kq2q7ak40 RnJvbSA1NWNjYWI3ZmJiZDVhMTYxMGNlNjMwZjE3ZTc5ZGI4YmRjNmI0ZDc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaGFybGF0YW4gSGVsbHNlaGVyIDxzaGFybGF0YW51c0BnbWFp bC5jb20+CkRhdGU6IEZyaSwgMTggSnVuIDIwMjEgMjA6Mjc6MjcgKzAxMDAKU3ViamVjdDogW1BB VENIXSBnbnU6IEFkZCBnb3BrZy5pbi95YW1sLnYzCgoqIGdudS9wYWNrYWdlcy9nb2xhbmcuc2Nt IChnby1nb3BrZy1pbi15bWwtdjMpOiBOZXcgdmFyaWFibGUKLS0tCiBnbnUvcGFja2FnZXMvZ29s YW5nLnNjbSB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEg ZmlsZSBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2Vz L2dvbGFuZy5zY20gYi9nbnUvcGFja2FnZXMvZ29sYW5nLnNjbQppbmRleCA4YzNjODFjZWRhLi4x OWE3MGM3YTgyIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ29sYW5nLnNjbQorKysgYi9nbnUv cGFja2FnZXMvZ29sYW5nLnNjbQpAQCAtMjUsNiArMjUsNyBAQAogOzs7IENvcHlyaWdodCDCqSAy MDIwIE1hcnRpbiBCZWN6ZSA8bWpiZWN6ZUByaXNldXAubmV0PgogOzs7IENvcHlyaWdodCDCqSAy MDIxIFJpY2FyZG8gV3VybXVzIDxyZWthZG9AZWxlcGhseS5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKp IDIwMjEgR3VpbGxhdW1lIExlIFZhaWxsYW50IDxnbHZAcG9zdGVvLm5ldD4KKzs7OyBDb3B5cmln aHQgwqkgMjAyMSBTaGFybGF0YW4gSGVsbHNlaGVyIDxzaGFybGF0YW51c0BtZ2FpbC5jb20+CiA7 OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMjQxMyw2ICsy NDE0LDQ1IEBAIHdoaWNoIHNhdGlzZmllcyB0aGUgY3JvbiBleHByZXNzaW9uLiIpCiB2YWx1ZXMu IikKICAgICAobGljZW5zZSBsaWNlbnNlOmFzbDIuMCkpKQogCisoZGVmaW5lLXB1YmxpYyBnby1n b3BrZy1pbi15YW1sLXYzCisgIChwYWNrYWdlCisgICAgKG5hbWUgImdvLWdvcGtnLWluLXlhbWwt djMiKQorICAgICh2ZXJzaW9uICIzIikKKyAgICAoc291cmNlCisgICAgICAob3JpZ2luCisgICAg ICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAg ICAgICAgICAgICAodXJsICJodHRwczovL2dvcGtnLmluL3lhbWwudjMuZ2l0IikKKyAgICAgICAg ICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgInYiIHZlcnNpb24pKSkpCisgICAgICAgIChm aWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgKHNoYTI1Ngor ICAgICAgICAgKGJhc2UzMiAiMDZmNGxucnA0OTR3cWF5Z3YwOWRnZ3IyZHdmM3oyYmF3cWhubG5u d2lhbWc1eTc4N2s0ZyIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnby1idWlsZC1zeXN0ZW0pCisg ICAgKGFyZ3VtZW50cworICAgICAnKCM6aW1wb3J0LXBhdGggImdvcGtnLmluL3lhbWwudjMiKSkK KyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgiZ28tZ29wa2ctaW4tY2hlY2stdjEiICxnby1n b3BrZy1pbi1jaGVjay12MSkpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ29wa2cuaW4veWFt bC52MyIpCisgICAgKHN5bm9wc2lzICJZQU1MIHJlYWRlciBhbmQgd3JpdGVyIGZvciB0aGUgR28g bGFuZ3VhZ2UiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiVGhpcyBwYWNrYWdlIHByb3ZpZGVz IGEgR28gbGlicmFyeSBmb3IgZW5jb2RlIGFuZCBkZWNvZGUgWUFNTAordmFsdWVzLgorCit2MyBz cGVjaWZpY2F0aW9uIGRpZmZlcmVuY2U6CitAaXRlbWl6ZQorQGl0ZW0gWUFNTCAxLjEgYm9vbHMg KHllcy9ubywgb24vb2ZmKSBhcmUgc3VwcG9ydGVkIGFzIGxvbmcgYXMgdGhleSBhcmUKK2JlaW5n IGRlY29kZWQgaW50byBhIHR5cGVkIGJvb2wgdmFsdWUuICBPdGhlcndpc2UgdGhleSBiZWhhdmUg YXMgYSBzdHJpbmcuCitCb29sZWFucyBpbiBZQU1MIDEuMiBhcmUgdHJ1ZS9mYWxzZSBvbmx5Lgor CitAaXRlbSBPY3RhbHMgZW5jb2RlIGFuZCBkZWNvZGUgYXMgMDc3NyBwZXIgWUFNTCAxLjEsIHJh dGhlciB0aGFuIDBvNzc3IGFzCitzcGVjaWZpZWQgaW4gWUFNTCAxLjIsIGJlY2F1c2UgbW9zdCBw YXJzZXJzIHN0aWxsIHVzZSB0aGUgb2xkIGZvcm1hdC4gIE9jdGFscyBpbgordGhlIDBvNzc3IGZv cm1hdCBhcmUgc3VwcG9ydGVkIHRob3VnaCwgc28gbmV3IGZpbGVzIHdvcmsuCisKK0BpdGVtIERv ZXMgbm90IHN1cHBvcnQgYmFzZS02MCBmbG9hdHMuICBUaGVzZSBhcmUgZ29uZSBmcm9tIFlBTUwg MS4yLCBhbmQgd2VyZQorYWN0dWFsbHkgbmV2ZXIgc3VwcG9ydGVkIGJ5IHRoaXMgcGFja2FnZSBh cyBpdCdzIGNsZWFybHkgYSBwb29yIGNob2ljZS4KK0BlbmQgaXRlbWl6ZSIpCisgICAgKGxpY2Vu c2UgbGljZW5zZTphc2wyLjApKSkKKwogKGRlZmluZS1wdWJsaWMgZ28tZ2l0aHViLWNvbS1tYXR0 bi1nby1pc2F0dHkKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZ28tZ2l0aHViLWNvbS1tYXR0bi1n by1pc2F0dHkiKQotLSAKMi4zMi4wCgo= --000000000000d20d4805c50f5886--