unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 39642@debbugs.gnu.org
Subject: [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals.
Date: Mon, 17 Feb 2020 23:19:12 +0100	[thread overview]
Message-ID: <CAJ3okZ3dCBtX5VS8KEobBikMr0hnZMoc5CHjAC=1YQFR4ETXTg@mail.gmail.com> (raw)
In-Reply-To: <20200217134027.731-1-mail@ambrevar.xyz>

Hi Pierre,

On which commit, do you apply this patch?
Maybe I am doing wrong, but it is not the file
'guix/scripts/describe.scm' but instead 'guix/scripts/describe.scm'.


On Mon, 17 Feb 2020 at 14:41, Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> diff --git a/guix/scripts/describe.scm b/guix/scripts/describe.scm
> index f13f221da9..9a7bd52163 100644
> --- a/guix/scripts/describe.scm
> +++ b/guix/scripts/describe.scm
> @@ -201,7 +201,12 @@ way and displaying details about the channel's source code."

This does not apply on master. What do I miss?
Because on my checkout, the file which is impacted is 'guix/scripts/pull.scm'.

[...]

> diff --git a/guix/ui.scm b/guix/ui.scm
> index dce97fb7b9..7e3251446f 100644
> --- a/guix/ui.scm
> +++ b/guix/ui.scm
> @@ -1636,7 +1636,7 @@ DURATION-RELATION with the current time."

This seems correct.


All the best,
simon

  parent reply	other threads:[~2020-02-17 22:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 13:40 [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals Pierre Neidhardt
2020-02-17 13:42 ` [bug#39642] [PATCH 2/3] ui: Don't disable colors when INSIDE_EMACS is set Pierre Neidhardt
2020-02-17 13:42   ` [bug#39642] [PATCH 3/3] ui: Don't truncate search output when inside Emacs Pierre Neidhardt
2020-02-17 16:05 ` [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals zimoun
2020-02-17 22:19 ` zimoun [this message]
2020-02-18  7:21   ` Pierre Neidhardt
2020-02-18  8:04     ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ3dCBtX5VS8KEobBikMr0hnZMoc5CHjAC=1YQFR4ETXTg@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=39642@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).