From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 39642@debbugs.gnu.org
Subject: [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals.
Date: Mon, 17 Feb 2020 17:05:45 +0100 [thread overview]
Message-ID: <CAJ3okZ1++ecdo6=-ormub=oeccYxnNqCrAUjPiS+XMamFbL-_Q@mail.gmail.com> (raw)
In-Reply-To: <20200217134027.731-1-mail@ambrevar.xyz>
Hi Pierre,
Thank you for looking at. :-)
On Mon, 17 Feb 2020 at 14:41, Pierre Neidhardt <mail@ambrevar.xyz> wrote:
> ---
> guix/scripts/describe.scm | 16 ++++++++++++----
> guix/ui.scm | 2 +-
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/guix/scripts/describe.scm b/guix/scripts/describe.scm
> index f13f221da9..9a7bd52163 100644
> --- a/guix/scripts/describe.scm
> +++ b/guix/scripts/describe.scm
> @@ -201,7 +201,12 @@ way and displaying details about the channel's source code."
> (format #t (G_ " commit: ~a~%")
> (if (supports-hyperlinks?)
> (channel-commit-hyperlink channel commit)
> - commit))))
> + commit))
> + (when (not (supports-hyperlinks?)
> + )
Issue on the closing parenthesis ')'.
Indent?
> @@ -233,9 +238,12 @@ way and displaying details about the channel's source code."
>
> (define* (channel-commit-hyperlink channel
> #:optional
> - (commit (channel-commit channel)))
> + (commit (channel-commit channel))
> + (transformer hyperlink))
> "Return a hyperlink for COMMIT in CHANNEL, using COMMIT as the hyperlink's
> -text. The hyperlink links to a web view of COMMIT, when available."
> +text. The hyperlink links to a web view of COMMIT, when available.
> +TRANSFORMER is a procedure of 2 arguments, a URI and text, and returns a
I do not have tried with another 'transformer' than 'hyperlink' or
'identity'. :-)
Cheers,
simon
next prev parent reply other threads:[~2020-02-17 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 13:40 [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals Pierre Neidhardt
2020-02-17 13:42 ` [bug#39642] [PATCH 2/3] ui: Don't disable colors when INSIDE_EMACS is set Pierre Neidhardt
2020-02-17 13:42 ` [bug#39642] [PATCH 3/3] ui: Don't truncate search output when inside Emacs Pierre Neidhardt
2020-02-17 16:05 ` zimoun [this message]
2020-02-17 22:19 ` [bug#39642] [PATCH 1/3] ui: Only display link in capable terminals zimoun
2020-02-18 7:21 ` Pierre Neidhardt
2020-02-18 8:04 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ1++ecdo6=-ormub=oeccYxnNqCrAUjPiS+XMamFbL-_Q@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=39642@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).