unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 38455@debbugs.gnu.org
Subject: [bug#38455] [PATCH] doc: Mention how to test against make / guix pull breakage.
Date: Mon, 2 Dec 2019 13:08:07 +0100	[thread overview]
Message-ID: <CAJ3okZ3Nu2tTB7oFT6ttsfznfEgz9-aSRArgy=Erg9F5E-LqDw@mail.gmail.com> (raw)
In-Reply-To: <20191202091550.15132-1-mail@ambrevar.xyz>

Hi Pierre,

On Mon, 2 Dec 2019 at 10:16, Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> * doc/contributing.texi (Submitting Patches): Mention commands in the check
>   list.

Nice!

I propose instead this wording. Because, I am not sure that building
Guix from source is really necessary to run/check "guix pull".


--8<---------------cut here---------------start------------->8---
diff --git a/doc/contributing.texi b/doc/contributing.texi
index ee72b2f94d..8001b0aef1 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -961,6 +961,15 @@ often better to clone the repository.  Don't use
the @command{name} field in
 the URL: it is not very useful and if the name changes, the URL will probably
 be wrong.

+@item
+Make sure your changes do not break @command{guix pull}:
+
+@example
+guix pull --dry-run --url=/path/to/your/checkout
+@end example
+
+(see @pxref{Invoking guix pull}).
+
 @end enumerate

 When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as
--8<---------------cut here---------------end--------------->8---


Hope that helps.

Cheers,
simon

  reply	other threads:[~2019-12-02 12:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  9:15 [bug#38455] [PATCH] doc: Mention how to test against make / guix pull breakage Pierre Neidhardt
2019-12-02 12:08 ` zimoun [this message]
2019-12-02 12:16   ` Pierre Neidhardt
2019-12-02 12:32     ` zimoun
2019-12-02 12:48       ` zimoun
2019-12-02 19:31 ` Danny Milosavljevic
2019-12-02 20:14   ` Pierre Neidhardt
2019-12-02 21:48     ` Danny Milosavljevic
2019-12-03 10:39       ` zimoun
2019-12-03 10:34   ` zimoun
2019-12-08 15:42     ` Pierre Neidhardt
2019-12-12 15:55       ` zimoun
2019-12-13 12:32         ` Pierre Neidhardt
2019-12-13 12:32           ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ3Nu2tTB7oFT6ttsfznfEgz9-aSRArgy=Erg9F5E-LqDw@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=38455@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).