From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48433)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibkVn-0005q9-C1
 for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibkVi-0003Kl-HO
 for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:07 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:59442)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ibkVi-0003Kd-Cu
 for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibkVh-0000Iq-Vf
 for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:02 -0500
Subject: [bug#38455] [PATCH] doc: Mention how to test against make / guix pull
 breakage.
Resent-Message-ID: <handler.38455.B38455.15752885061108@debbugs.gnu.org>
MIME-Version: 1.0
References: <20191202091550.15132-1-mail@ambrevar.xyz>
In-Reply-To: <20191202091550.15132-1-mail@ambrevar.xyz>
From: zimoun <zimon.toutoune@gmail.com>
Date: Mon, 2 Dec 2019 13:08:07 +0100
Message-ID: <CAJ3okZ3Nu2tTB7oFT6ttsfznfEgz9-aSRArgy=Erg9F5E-LqDw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 38455@debbugs.gnu.org

Hi Pierre,

On Mon, 2 Dec 2019 at 10:16, Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> * doc/contributing.texi (Submitting Patches): Mention commands in the check
>   list.

Nice!

I propose instead this wording. Because, I am not sure that building
Guix from source is really necessary to run/check "guix pull".


--8<---------------cut here---------------start------------->8---
diff --git a/doc/contributing.texi b/doc/contributing.texi
index ee72b2f94d..8001b0aef1 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -961,6 +961,15 @@ often better to clone the repository.  Don't use
the @command{name} field in
 the URL: it is not very useful and if the name changes, the URL will probably
 be wrong.

+@item
+Make sure your changes do not break @command{guix pull}:
+
+@example
+guix pull --dry-run --url=/path/to/your/checkout
+@end example
+
+(see @pxref{Invoking guix pull}).
+
 @end enumerate

 When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as
--8<---------------cut here---------------end--------------->8---


Hope that helps.

Cheers,
simon