unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 38846@debbugs.gnu.org
Subject: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access.
Date: Wed, 1 Jan 2020 19:51:50 +0100	[thread overview]
Message-ID: <CAJ3okZ33cJ0W834Rw=wka27hqzqWAhRv6NXniXVi=QWssa9YuQ@mail.gmail.com> (raw)
In-Reply-To: <20200101163446.5132-4-ludo@gnu.org>

Hi,

Nice proposal!


On Wed, 1 Jan 2020 at 17:36, Ludovic Courtès <ludo@gnu.org> wrote:

> +Committers are expected to have had some interactions with you as a
> +contributor and to be able to judge whether you are sufficiently
> +familiar with the project's practices.  It is @emph{not} a judgment on
> +the quality of your work, so a refusal should rather be interpreted as
> +``let's try again later''.

Cutting the hairs: on one hand "be able to judge" on practices and on
the other hand "not a judgment on the quality".
Even if I understand the idea behind (I guess), I do not find it well
worded, if I might.
I mean, I bet that "the quality of work" is a strong part when
motivating the acceptance or the refusal, so yes it is "a judgment on
the quality of your work" (but not only).
Quality implies standards and practices; quality can be measured (more
or less). From my understanding.

Instead of 'quality', I propose 'value' which is more subjective.

Well, my English is not very good...


> +However, note that the project is working towards a more automated patch
> +review and merging system, which, as a consequence, may lead us to have
> +fewer people with commit access to the main repository.  Stay tuned!
> +@end quotation

I find inappropriate the "Stay tuned!" in the manual.


Cheers,
simon

  parent reply	other threads:[~2020-01-01 18:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01 16:29 [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access Ludovic Courtès
2020-01-01 16:34 ` [bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section Ludovic Courtès
2020-01-01 16:34   ` [bug#38846] [PATCH 2/4] doc: Move "Commit Access" section from 'HACKING' to the manual Ludovic Courtès
2020-01-01 18:08     ` Ricardo Wurmus
2020-01-01 16:34   ` [bug#38846] [PATCH 3/4] doc: Encourage patch review Ludovic Courtès
2020-01-01 18:09     ` Ricardo Wurmus
2020-01-01 16:34   ` [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access Ludovic Courtès
2020-01-01 18:15     ` Ricardo Wurmus
2020-01-02 11:20       ` Ludovic Courtès
2020-01-07 22:36         ` Maxim Cournoyer
2020-01-01 18:51     ` zimoun [this message]
2020-01-02 11:53       ` Ludovic Courtès
2020-01-02 18:35         ` zimoun
2020-01-06  9:30           ` Ludovic Courtès
2020-01-02  4:09     ` Brett Gilio
2020-01-02 11:15       ` Ricardo Wurmus
2020-01-02 11:59       ` Ludovic Courtès
2020-01-06 23:29     ` Tobias Geerinckx-Rice via Guix-patches via
2020-01-06 23:34       ` Tobias Geerinckx-Rice via Guix-patches via
2020-01-07  0:19       ` Brett Gilio
2020-01-07 11:27         ` zimoun
2020-01-09 22:39       ` bug#38846: " Ludovic Courtès
2020-01-01 18:07   ` [bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section Ricardo Wurmus
2020-01-01 18:18   ` zimoun
2020-01-02 11:51     ` Ludovic Courtès
2020-01-02 18:40       ` zimoun
2020-01-01 18:37 ` [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access Ricardo Wurmus
2020-01-06 13:13 ` Ludovic Courtès
2020-01-07 22:50   ` Marius Bakke
2020-01-06 21:44 ` zimoun
2020-01-07 11:17   ` Ludovic Courtès
2020-01-09 22:05   ` Ludovic Courtès
2020-01-10 15:49     ` zimoun
2020-01-13 10:01       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ33cJ0W834Rw=wka27hqzqWAhRv6NXniXVi=QWssa9YuQ@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=38846@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).