From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 38678@debbugs.gnu.org
Subject: [bug#38678] [PATCH 2/2] size: Add '--load-path' option.
Date: Thu, 19 Dec 2019 22:43:23 +0100 [thread overview]
Message-ID: <CAJ3okZ1fYQDmbfWyqCq5HdaSPqXzOOLXzoRB9Xy=MMsCH_ayLA@mail.gmail.com> (raw)
In-Reply-To: <87sglgq9rs.fsf@ambrevar.xyz>
On Thu, 19 Dec 2019 at 22:35, Pierre Neidhardt <mail@ambrevar.xyz> wrote:
> I haven't tested, but otherwise looks good to me!
What do you think about the missing test?
Could also comment the cover letter (guix refresh, guix edit, etc.)?
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38678#5
> > diff --git a/doc/guix.texi b/doc/guix.texi
> > index 02f7cf5b39..c0fa6a3cab 100644
> > --- a/doc/guix.texi
> > +++ b/doc/guix.texi
> > @@ -69,7 +69,6 @@ Copyright @copyright{} 2019 Jakob L. Kreuze@*
> > Copyright @copyright{} 2019 Kyle Andrews@*
> > Copyright @copyright{} 2019 Alex Griffin@*
> > Copyright @copyright{} 2019 Guillaume Le Vaillant@*
> > -Copyright @copyright{} 2019 Simon Tournier@*
>
> Did you remove the copyright line by mistake?
Maybe. :-)
Cheers,
simon
next prev parent reply other threads:[~2019-12-19 21:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 21:09 [bug#38678] [PATCH 0/2] Add '--load-path' to subcommands zimoun
2019-12-19 21:13 ` [bug#38678] [PATCH 1/2] graph: Add '--load-path' option zimoun
2019-12-19 21:14 ` [bug#38678] [PATCH 2/2] size: " zimoun
2019-12-19 21:35 ` Pierre Neidhardt
2019-12-19 21:43 ` zimoun [this message]
2019-12-19 21:48 ` Pierre Neidhardt
2020-01-08 18:53 ` [bug#38678] [PATCH v2 0/4] Add '--load-path' to subcommands zimoun
2020-01-08 19:12 ` [bug#38678] [PATCH v3] better filter in 'refresh' zimoun
2020-01-08 18:56 ` [bug#38678] [PATCH v2 1/4] graph: Add '--load-path' option zimoun
2020-01-08 18:56 ` [bug#38678] [PATCH v2 2/4] size: " zimoun
2020-01-08 18:56 ` [bug#38678] [PATCH v2 3/4] refresh: " zimoun
2020-01-08 18:56 ` [bug#38678] [PATCH v2 4/4] edit: " zimoun
2020-01-08 19:12 ` [bug#38678] [PATCH v3] refresh: " zimoun
2020-01-08 20:59 ` [bug#38678] what about "guix repl"? zimoun
2020-01-08 21:27 ` Pierre Neidhardt
2020-01-09 13:19 ` zimoun
2020-01-09 13:21 ` [bug#38678] [PATCH 1/2] repl: Add '--load-path' option zimoun
2020-01-09 13:21 ` [bug#38678] [PATCH 2/2] repl: Fix '--help' message zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 1/6] graph: Add '--load-path' option zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 2/6] size: " zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 3/6] refresh: " zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 4/6] edit: " zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 5/6] repl: " zimoun
2020-01-15 17:00 ` [bug#38678] [PATCH v4 6/6] repl: Fix '--help' message zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ1fYQDmbfWyqCq5HdaSPqXzOOLXzoRB9Xy=MMsCH_ayLA@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=38678@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).