From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33489)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii3aZ-00031i-71
 for guix-patches@gnu.org; Thu, 19 Dec 2019 16:44:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii3aU-0008Nl-Ex
 for guix-patches@gnu.org; Thu, 19 Dec 2019 16:44:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39649)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ii3aU-0008M1-67
 for guix-patches@gnu.org; Thu, 19 Dec 2019 16:44:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ii3aU-0004qt-3I
 for guix-patches@gnu.org; Thu, 19 Dec 2019 16:44:02 -0500
Subject: [bug#38678] [PATCH 2/2] size: Add '--load-path' option.
Resent-Message-ID: <handler.38678.B38678.157679182118618@debbugs.gnu.org>
MIME-Version: 1.0
References: <20191219210958.8807-1-zimon.toutoune@gmail.com>
 <20191219211400.8978-1-zimon.toutoune@gmail.com> <87sglgq9rs.fsf@ambrevar.xyz>
In-Reply-To: <87sglgq9rs.fsf@ambrevar.xyz>
From: zimoun <zimon.toutoune@gmail.com>
Date: Thu, 19 Dec 2019 22:43:23 +0100
Message-ID: <CAJ3okZ1fYQDmbfWyqCq5HdaSPqXzOOLXzoRB9Xy=MMsCH_ayLA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 38678@debbugs.gnu.org

On Thu, 19 Dec 2019 at 22:35, Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> I haven't tested, but otherwise looks good to me!

What do you think about the missing test?

Could also comment the cover letter (guix refresh, guix edit, etc.)?
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38678#5


> > diff --git a/doc/guix.texi b/doc/guix.texi
> > index 02f7cf5b39..c0fa6a3cab 100644
> > --- a/doc/guix.texi
> > +++ b/doc/guix.texi
> > @@ -69,7 +69,6 @@ Copyright @copyright{} 2019 Jakob L. Kreuze@*
> >  Copyright @copyright{} 2019 Kyle Andrews@*
> >  Copyright @copyright{} 2019 Alex Griffin@*
> >  Copyright @copyright{} 2019 Guillaume Le Vaillant@*
> > -Copyright @copyright{} 2019 Simon Tournier@*
>
> Did you remove the copyright line by mistake?

Maybe. :-)


Cheers,
simon