From: zimoun <zimon.toutoune@gmail.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
51091@debbugs.gnu.org, "Xinglu Chen" <public@yoctocell.xyz>
Subject: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing.
Date: Fri, 19 Nov 2021 12:30:20 +0100 [thread overview]
Message-ID: <CAJ3okZ0OMY3PgoJ3DdiyQNFo3ows8M42CisrkcFZVO77+-jh3g@mail.gmail.com> (raw)
In-Reply-To: <83620617-04DC-472D-80B8-300044832A37@lepiller.eu>
Hi Julien,
On Fri, 19 Nov 2021 at 12:21, Julien Lepiller <julien@lepiller.eu> wrote:
> >> I forgot to remove the catch #t around the whole body of the function.
> >> I noticed that guard* was raising &non-continuable so I tried to fix it
> >> by using raise-continuable from (ice-9 exceptions). Is this the correct
> >> solution?
> >
> >I suppose, though I’m not sure why it needs to be continuable: you could
> >just catch the exception and move on to the next package?
>
> I don't understand how to catch the exception though, unless you mean wrap everything with catch #t, which kinda defeats the purpose of having a condition in the first pjace. guard* raises &non-continuable unless the condition is continuable, or I'm missing something in the way I use it. I have no idea what a continuable exception is, so let me just push the other patch.
>
> (guard* (c ((opam-error? c) #f)))
> (raise (condition (&opam-error …))))
>
> Doesn't return #f as I expect, but raises &non-continuable.
I sympathize and I had / is still having hard time with similar use
cases. That's one of the reasons (among my laziness :-)) that [1] is
not fixed yet. :-)
1: <1: <http://issues.guix.gnu.org/issue/45984>
> Hopefully someone smarter than me can figure it out. I'll push the other patch, although I don't like the double warning in the updater.
I agree. And move all G_ strings to guix/scripts/ is a good idea, IMHO.
Well, I do not know. :-)
(I secretly hoped that you would be the smarter than me person fixing
the recursive importers. ;-))
Cheers,
simon
prev parent reply other threads:[~2021-11-19 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 3:03 [bug#51091] [PATCH] guix: opam: Do not fail when refreshing Julien Lepiller
2021-10-09 9:39 ` Xinglu Chen
2021-10-14 13:01 ` Ludovic Courtès
2021-10-16 2:10 ` [bug#51091] [PATCH v2] " Julien Lepiller
2021-10-18 8:39 ` Ludovic Courtès
2021-11-19 1:16 ` [bug#51091] [PATCH v3] " Julien Lepiller
2021-11-19 1:43 ` zimoun
2021-11-19 9:16 ` Ludovic Courtès
2021-11-19 9:40 ` zimoun
2021-11-19 11:19 ` Julien Lepiller
2021-11-19 11:30 ` zimoun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ0OMY3PgoJ3DdiyQNFo3ows8M42CisrkcFZVO77+-jh3g@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=51091@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=ludo@gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).