From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mI6qCwGLl2FoXAAAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 12:31:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cGtFBwGLl2H7GwAAbx9fmQ (envelope-from ) for ; Fri, 19 Nov 2021 11:31:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F58937880 for ; Fri, 19 Nov 2021 12:31:12 +0100 (CET) Received: from localhost ([::1]:33122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo26p-00056D-Nk for larch@yhetil.org; Fri, 19 Nov 2021 06:31:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo26h-00055c-LK for guix-patches@gnu.org; Fri, 19 Nov 2021 06:31:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo26h-0005n6-Ca for guix-patches@gnu.org; Fri, 19 Nov 2021 06:31:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo26g-00061K-3K for guix-patches@gnu.org; Fri, 19 Nov 2021 06:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51091 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 51091@debbugs.gnu.org, Xinglu Chen Received: via spool by 51091-submit@debbugs.gnu.org id=B51091.163732143923102 (code B ref 51091); Fri, 19 Nov 2021 11:31:02 +0000 Received: (at 51091) by debbugs.gnu.org; 19 Nov 2021 11:30:39 +0000 Received: from localhost ([127.0.0.1]:38232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo26J-00060Y-9A for submit@debbugs.gnu.org; Fri, 19 Nov 2021 06:30:39 -0500 Received: from mail-io1-f45.google.com ([209.85.166.45]:43565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo26H-00060J-0x for 51091@debbugs.gnu.org; Fri, 19 Nov 2021 06:30:37 -0500 Received: by mail-io1-f45.google.com with SMTP id z26so12302975iod.10 for <51091@debbugs.gnu.org>; Fri, 19 Nov 2021 03:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9W3zbutcJq0UVXsOypw0B2Fn6dZvE3ZWcq08LxJT7vE=; b=TneorG1iu6eEtTnXRVCjw7RrKOlPYYr34TEqkJWBLMjLG/U3ybrsX/crs5/ZqT8MK0 vGJ5NN7vPRERpOs7MSXXu5dYckwcoMpOvpeVue1dLMMTdmmLzyG7nlhcQsJ+InCvQpCj Th8M6qLsPdtGNEPcGpw78DsgGsaC9eBpLcjW7Wnin8iqB1AdvbZJ/D1Hlkio5TbfhCH1 jYFzg6acbfTBPE/K0dLecV8GJb40C1LLCyU8HhHDt0sKDaPfZrl16B+vbt5JUMgPH13r F75tkIjPEH/bIW3pgK3ZogSre0CkurZuMeGhdAtvCyX3MfKZzxed1VuWf22fDs9TjPSa KXfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9W3zbutcJq0UVXsOypw0B2Fn6dZvE3ZWcq08LxJT7vE=; b=DfqMWyvg9HicQnHr2YDyfN7+qJoCR47I4lOX8vBIAwO5TAMPjdk1A3e9eA73L7DeAR vrRGQMPm4VSyd+V1fZNEnf1TvDeYuTF7uvBMU20qzX7UZECOe7+A8CVK2WKm5Uu2Zss9 TxbH2kaMMvNN79TKu5Fl2GxMGhi++Ifvt5fGyGUnO7ZxjTrAhl1fUlIEmHIm5pW7g8fi nAx/XDnAs3iaoRYIJQ8SGZabLz1QsoorPQ4hZ9AOBXyYsLLvsj1j7byW29FSBdYnFpSY 3i3Qeh6dpmeNs6GvBl5iNqmNsLBT2gLmmckyrfGs18GJOaZpuCCNOx6hNQ2zs8fcScbk 33Gw== X-Gm-Message-State: AOAM530xUj4cCxm6DKzwVWNT99XBmWPTln4vG5zwGPQUC/BCFs+q7QPa qW0TP2G1mnMS47IjSkJ3PfJdGD6tqbgyxRWkwc4= X-Google-Smtp-Source: ABdhPJzn+nVBfRCe+yqDWUijn05qZroI8keO6YhYWGrC+ECLTF9VWM76ZZeBnwQYoFhsfm8l6qtVqY0IG6ZixqXzQ6c= X-Received: by 2002:a5d:9b0f:: with SMTP id y15mr4774002ion.5.1637321431425; Fri, 19 Nov 2021 03:30:31 -0800 (PST) MIME-Version: 1.0 References: <20211008050310.407d6b23@tachikoma.lepiller.eu> <87y272lepg.fsf@yoctocell.xyz> <871r4nrc9t.fsf_-_@gnu.org> <20211016041009.5b4ddff0@tachikoma.lepiller.eu> <87sfwybuc7.fsf@gnu.org> <20211119021646.03e85542@tachikoma.lepiller.eu> <87czmwo68f.fsf@gnu.org> <83620617-04DC-472D-80B8-300044832A37@lepiller.eu> In-Reply-To: <83620617-04DC-472D-80B8-300044832A37@lepiller.eu> From: zimoun Date: Fri, 19 Nov 2021 12:30:20 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637321472; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9W3zbutcJq0UVXsOypw0B2Fn6dZvE3ZWcq08LxJT7vE=; b=HjNyuo1bGfnOjYbUt9Iars+QBYJCqnDUHIetaSAKPI6xgxFQ2OxbaMPkCmRjUH9tdtSLX7 /XpZL3MG9omflwHVjeokSDpS45EnwJw1jsZeZZZtctPtwZ4eGsRF9HLaknWQA9JQlyvc7R rTd0g7E/Palar7i1i2iH2P96AyE3+g4Gh6gAlSomlex1On4UHFBRPnaYY6rBhDRxC92okj WMqpmAci+iru2Ybs6CnQBMPwXjQWcFzTXWr3isKYhW9MA0KbyKL0xMNXAztVLyCQIOdb5g y482bNbChyWG8LSXG6YmsdRYw3oib+XQCUmI0bSoQABR22TwXStjhlWs+jA6uw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637321472; a=rsa-sha256; cv=none; b=uRAnAVT6WzBHVg8lumsJpN5kBfK+NXyRoDu8P9jaJZw8JjmLduz6Y3mXyW5B73/9SRhAfo FG2VLBTxH26LxYzENgRi5MV91VSUUijBHO0pQbX0+npcGO7iCmZxkwx595SeeQMZVhafev BB8KUpXHjIMgMS/jkkFzXhtghqet+dpufYz8hm7oyLDBStmnBI2cuAmOV30HzFDVQrY5Vy iapwQclu3XD9QUPRaHSgOEPS7ixnFGPO8eJTsxUuhDap424XJu3mlHjsowedZI4p2IQeJb s8s9k1ojygKuRsnAiPgLR+aFpd01U4COJY/QmA0i0ocfRW9DO2JxAEJ2ZiHGhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TneorG1i; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TneorG1i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9F58937880 X-Spam-Score: -1.76 X-Migadu-Scanner: scn1.migadu.com X-TUID: V4V18pTNhsU1 Hi Julien, On Fri, 19 Nov 2021 at 12:21, Julien Lepiller wrote: > >> I forgot to remove the catch #t around the whole body of the function. > >> I noticed that guard* was raising &non-continuable so I tried to fix i= t > >> by using raise-continuable from (ice-9 exceptions). Is this the correc= t > >> solution? > > > >I suppose, though I=E2=80=99m not sure why it needs to be continuable: y= ou could > >just catch the exception and move on to the next package? > > I don't understand how to catch the exception though, unless you mean wra= p everything with catch #t, which kinda defeats the purpose of having a con= dition in the first pjace. guard* raises &non-continuable unless the condit= ion is continuable, or I'm missing something in the way I use it. I have no= idea what a continuable exception is, so let me just push the other patch. > > (guard* (c ((opam-error? c) #f))) > (raise (condition (&opam-error =E2=80=A6)))) > > Doesn't return #f as I expect, but raises &non-continuable. I sympathize and I had / is still having hard time with similar use cases. That's one of the reasons (among my laziness :-)) that [1] is not fixed yet. :-) 1: <1: > Hopefully someone smarter than me can figure it out. I'll push the other = patch, although I don't like the double warning in the updater. I agree. And move all G_ strings to guix/scripts/ is a good idea, IMHO. Well, I do not know. :-) (I secretly hoped that you would be the smarter than me person fixing the recursive importers. ;-)) Cheers, simon