From: Vincent Legoll <vincent.legoll@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 40032-done@debbugs.gnu.org
Subject: [bug#40032] [PATCH] gnu: Add nvme-cli
Date: Sun, 15 Mar 2020 19:10:18 +0100 [thread overview]
Message-ID: <CAEwRq=p6ObsJiWrs-EDw7vK5BfbGCjP4Yvwvvxvh-SrMQaGBEg@mail.gmail.com> (raw)
In-Reply-To: <20200315175722.GE26892@jasmine.lan>
Thanks for all the fixes, I'll try to get better at doing that myself...
On Sun, Mar 15, 2020 at 6:57 PM Leo Famulari <leo@famulari.name> wrote:
>
> On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote:
> > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001
> > From: Vincent Legoll <vincent.legoll@gmail.com>
> > Date: Thu, 12 Mar 2020 01:51:12 +0100
> > Subject: [PATCH] gnu: Add nvme-cli
> >
> > * gnu/packages/linux.scm (nvme-cli): New variable.
>
> Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the
> following changes that I somehow forgot to mention. There was no need to
> make you revise the patch again...
>
> > + #:phases (modify-phases %standard-phases
> > + (delete 'configure)
>
> I added a comment about why the phase is deleted.
>
> > + (replace 'install
> > + (lambda _
> > + (zero? (system* "make" "install-spec" "PREFIX="
> > + (string-append "DESTDIR=" %output))))))
>
> I replaced (zero? (system* ...)) with (invoke ...), which raises
> exceptions on failure rather than returning a boolean #f. This is "the
> Guix way" for a while now:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html
>
> > + (description "Utility to provide standards compliant tooling for NVM-Express
> > +drives. It was made specifically for Linux as it relies on the IOCTLs defined
>
> And I made this first sentence into a complete sentence.
--
Vincent Legoll
next prev parent reply other threads:[~2020-03-15 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 1:13 [bug#40032] [PATCH] gnu: Add nvme-cli Vincent Legoll
2020-03-12 18:15 ` Leo Famulari
2020-03-13 23:14 ` Vincent Legoll
2020-03-15 17:07 ` Vincent Legoll
2020-03-15 17:22 ` Leo Famulari
2020-03-15 17:36 ` Vincent Legoll
2020-03-15 17:57 ` bug#40032: " Leo Famulari
2020-03-15 18:10 ` Vincent Legoll [this message]
2020-03-15 18:21 ` [bug#40032] " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=p6ObsJiWrs-EDw7vK5BfbGCjP4Yvwvvxvh-SrMQaGBEg@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=40032-done@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).