unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40032@debbugs.gnu.org
Subject: [bug#40032] [PATCH] gnu: Add nvme-cli
Date: Sun, 15 Mar 2020 13:22:42 -0400	[thread overview]
Message-ID: <20200315172242.GA26892@jasmine.lan> (raw)
In-Reply-To: <CAEwRq=pMDGyhQvOBMex6PXYx+2W71kZGHGx3p_v=26APXbtw8w@mail.gmail.com>

On Sun, Mar 15, 2020 at 06:07:44PM +0100, Vincent Legoll wrote:
> It looks like the tests require the presence of /sys/devices...
> 
> Should I just add that explanation as comment ?

Yeah, I would say that they require sysfs, which is not accessible from
the build environment.

One could check with "ls -l /sys" in a build phase, or check the docs:

https://guix.gnu.org/manual/en/html_node/Build-Environment-Setup.html

Can you send a revised patch?

  reply	other threads:[~2020-03-15 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  1:13 [bug#40032] [PATCH] gnu: Add nvme-cli Vincent Legoll
2020-03-12 18:15 ` Leo Famulari
2020-03-13 23:14   ` Vincent Legoll
2020-03-15 17:07     ` Vincent Legoll
2020-03-15 17:22       ` Leo Famulari [this message]
2020-03-15 17:36         ` Vincent Legoll
2020-03-15 17:57           ` bug#40032: " Leo Famulari
2020-03-15 18:10             ` [bug#40032] " Vincent Legoll
2020-03-15 18:21               ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315172242.GA26892@jasmine.lan \
    --to=leo@famulari.name \
    --cc=40032@debbugs.gnu.org \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).