unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gábor Boskovits" <boskovits@gmail.com>
To: 29580@debbugs.gnu.org
Subject: [bug#29580] Acknowledgement ([PATCH] gnu: gtk+-2: Fix failing test.)
Date: Tue, 5 Dec 2017 20:59:59 +0100	[thread overview]
Message-ID: <CAE4v=pjqNMqjUTVtN+-LXEtodKV6VW2uSftEQj2RoWrXn8vqFg@mail.gmail.com> (raw)
In-Reply-To: <handler.29580.B.151250347132722.ack@debbugs.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]

This is a patch to make gtk2 build on core-updates.
Relevant details can be found on today irc logs.
Just the most important points:

gtk+-2 build fails on core-updates with a failing test: gtk/abitest.sh

The cause of the failure is that the new version of glib currently on
core-updates exposes a new marshaller, therefore the abi provided by the
library is a superset of the expected abi, and this test requires exact
match.

Here is a snippet of communcation with upstream:
17:49 < EmmanueleBassi> gabriel_: It's fine to ignore
17:49 < EmmanueleBassi> gabriel_: GLib added a new marshaller in its public
API
17:50 < EmmanueleBassi> gabriel_: And the `abicheck.sh`in GTK+ 2.24 hasn't
been updated because GTK+ 2.24 is in deep maintenance mode and very few
people test it against newer versions of GLib 17:50 < EmmanueleBassi>
There's the question as to whether GLib should have added a new marshaller
in the public API in the first place
[17:56] <g_bor> EmmanueleBassi> But that happened a long time ago

So it seems, that this is fine to ignore this, and upstream is not
interested in fixing it.

My fix restricts the test to the gtk abi, which I think is the good thing
to do.

2017-12-05 20:52 GMT+01:00 GNU bug Tracking System <help-debbugs@gnu.org>:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 29580@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 29580: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29580
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>

[-- Attachment #2: Type: text/html, Size: 4649 bytes --]

  parent reply	other threads:[~2017-12-05 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 19:50 [bug#29580] [PATCH] gnu: gtk+-2: Fix failing test Gábor Boskovits
     [not found] ` <handler.29580.B.151250347132722.ack@debbugs.gnu.org>
2017-12-05 19:59   ` Gábor Boskovits [this message]
2017-12-05 23:26 ` Danny Milosavljevic
2017-12-06 14:19 ` Gábor Boskovits
2017-12-06 19:41   ` Danny Milosavljevic
2017-12-07 17:02   ` bug#29580: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE4v=pjqNMqjUTVtN+-LXEtodKV6VW2uSftEQj2RoWrXn8vqFg@mail.gmail.com' \
    --to=boskovits@gmail.com \
    --cc=29580@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).