From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMJOu-0007UU-RG for guix-patches@gnu.org; Tue, 05 Dec 2017 15:01:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMJOp-0001GX-2g for guix-patches@gnu.org; Tue, 05 Dec 2017 15:01:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMJOo-0001G1-Tk for guix-patches@gnu.org; Tue, 05 Dec 2017 15:01:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eMJOo-0000KN-Kv for guix-patches@gnu.org; Tue, 05 Dec 2017 15:01:02 -0500 Subject: [bug#29580] Acknowledgement ([PATCH] gnu: gtk+-2: Fix failing test.) Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <20171205195028.32244-1-boskovits@gmail.com> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Tue, 5 Dec 2017 20:59:59 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c0b9c9ca2889b055f9d4730" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29580@debbugs.gnu.org --94eb2c0b9c9ca2889b055f9d4730 Content-Type: text/plain; charset="UTF-8" This is a patch to make gtk2 build on core-updates. Relevant details can be found on today irc logs. Just the most important points: gtk+-2 build fails on core-updates with a failing test: gtk/abitest.sh The cause of the failure is that the new version of glib currently on core-updates exposes a new marshaller, therefore the abi provided by the library is a superset of the expected abi, and this test requires exact match. Here is a snippet of communcation with upstream: 17:49 < EmmanueleBassi> gabriel_: It's fine to ignore 17:49 < EmmanueleBassi> gabriel_: GLib added a new marshaller in its public API 17:50 < EmmanueleBassi> gabriel_: And the `abicheck.sh`in GTK+ 2.24 hasn't been updated because GTK+ 2.24 is in deep maintenance mode and very few people test it against newer versions of GLib 17:50 < EmmanueleBassi> There's the question as to whether GLib should have added a new marshaller in the public API in the first place [17:56] EmmanueleBassi> But that happened a long time ago So it seems, that this is fine to ignore this, and upstream is not interested in fixing it. My fix restricts the test to the gtk abi, which I think is the good thing to do. 2017-12-05 20:52 GMT+01:00 GNU bug Tracking System : > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > guix-patches@gnu.org > > If you wish to submit further information on this problem, please > send it to 29580@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 29580: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29580 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > --94eb2c0b9c9ca2889b055f9d4730 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This is a patch to make gtk2 build on core-updates.
Re= levant details can be found on today irc logs.
Just the most impo= rtant points:

gtk+-2 build fails on core-updates w= ith a failing test: gtk/abitest.sh

The cause of th= e failure is that the new version of glib currently on core-updates exposes= a new marshaller, therefore the abi provided by the library is a superset = of the expected abi, and this test requires exact match.

Here is a snippet of communcation with upstream:
17:49 < EmmanueleBassi> gabriel_: It= 9;s fine to ignore
17:49 < E= mmanueleBassi> gabriel_: GLib added a new marshaller in its public API
17:50 < EmmanueleBassi> ga= briel_: And the `abicheck.sh`in GTK+ 2.24 hasn't been updated because G= TK+ 2.24 is in deep maintenance mode and very few people test it against ne= wer versions of GLib 17:50 < EmmanueleBassi> There's the question= as to whether GLib should have added a new marshaller in the public API in= the first place
[17:56]=C2=A0<g_bor> Emm= anueleBassi> But that happened a long time ago

S= o it seems, that this is fine to ignore this, and upstream is not intereste= d in fixing it.

My fix restricts the test to the gtk abi,= which I think is the good thing to do.

2017-12-05 20:52 GMT+01:00 GNU bug Tracki= ng System <help-debbugs@gnu.org>:
Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
=C2=A0guix-patches@gnu.org

If you wish to submit further information on this problem, please
send it to 29580@debbugs.gnu.org.

Please do not send mail to help-deb= bugs@gnu.org unless you wish
to report a problem with the Bug-tracking system.

--
29580: http://debbugs.gnu.org/cgi/bugreport= .cgi?bug=3D29580
GNU Bug Tracking System
Contact help-debbugs@gnu.org wi= th problems

--94eb2c0b9c9ca2889b055f9d4730--