From: "Gábor Boskovits" <boskovits@gmail.com>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 29897@debbugs.gnu.org
Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8.
Date: Thu, 25 Jan 2018 22:47:46 +0100 [thread overview]
Message-ID: <CAE4v=phbrp-cpfE=OOnjgRAZqVMpChU4ZWbSDBjAnAYCOkD0bg@mail.gmail.com> (raw)
In-Reply-To: <87r2qel1zl.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
It seems, that moving the tests and not moving the tesresources directory
breaks the relatitve paths in the tests.
Tomorrow I will check what happens if we also move the testresources.
2018-01-25 10:30 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
> Gábor Boskovits <boskovits@gmail.com> writes:
>
> > Thanks for the corrections.
> > Looks good to me,
> > I won't send an updated patch then.
> > Please commit with the modifications.
>
> I made the modifications and also tried to enable the tests (see
> attached patch), but I discovered that some of the tests are failing
> (and some are passing). Perhaps we should try fixing the tests while
> we're here? If you do
>
> /pre-inst-env guix build --keep-failed java-aqute-libg
>
> you can see the failures. The build directory will be kept. If we go
> to it, we can find a report of the test failures under the path:
>
> bnd-3.4.0.REL/aQute.libg/test/test-reports
>
> Unfortunately, the ant-build-system doesn't compile the classes with
> debug info by default. To enable line numbers etc. in the stack traces,
> we'll need to add
>
> debug="true"
>
> to the relevant <javac> tags, as described here:
>
> https://ant.apache.org/manual/Tasks/javac.html
>
> If you could help debug the failures, that would be nice. I will also
> look as I get time.
>
> --
> Chris
>
[-- Attachment #2: Type: text/html, Size: 2033 bytes --]
next prev parent reply other threads:[~2018-01-25 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 19:17 [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8 Gábor Boskovits
2018-01-17 8:30 ` Chris Marusich
2018-01-17 12:15 ` Gábor Boskovits
2018-01-25 9:30 ` Chris Marusich
2018-01-25 21:47 ` Gábor Boskovits [this message]
2018-01-26 9:58 ` Gábor Boskovits
2018-01-26 10:33 ` Gábor Boskovits
2018-06-24 16:13 ` bug#29897: " Gábor Boskovits
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=phbrp-cpfE=OOnjgRAZqVMpChU4ZWbSDBjAnAYCOkD0bg@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=29897@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).