From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eepNN-0004C5-3i for guix-patches@gnu.org; Thu, 25 Jan 2018 16:48:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eepNK-0007Vd-0f for guix-patches@gnu.org; Thu, 25 Jan 2018 16:48:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eepNJ-0007VX-Sh for guix-patches@gnu.org; Thu, 25 Jan 2018 16:48:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eepNJ-0002aU-Iq for guix-patches@gnu.org; Thu, 25 Jan 2018 16:48:01 -0500 Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <87r2qel1zl.fsf@gmail.com> References: <20171229191700.981-1-boskovits@gmail.com> <87zi5cga5w.fsf@gmail.com> <87r2qel1zl.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Thu, 25 Jan 2018 22:47:46 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c11cb4806e05d0563a0bb21" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29897@debbugs.gnu.org --94eb2c11cb4806e05d0563a0bb21 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It seems, that moving the tests and not moving the tesresources directory breaks the relatitve paths in the tests. Tomorrow I will check what happens if we also move the testresources. 2018-01-25 10:30 GMT+01:00 Chris Marusich : > G=C3=A1bor Boskovits writes: > > > Thanks for the corrections. > > Looks good to me, > > I won't send an updated patch then. > > Please commit with the modifications. > > I made the modifications and also tried to enable the tests (see > attached patch), but I discovered that some of the tests are failing > (and some are passing). Perhaps we should try fixing the tests while > we're here? If you do > > /pre-inst-env guix build --keep-failed java-aqute-libg > > you can see the failures. The build directory will be kept. If we go > to it, we can find a report of the test failures under the path: > > bnd-3.4.0.REL/aQute.libg/test/test-reports > > Unfortunately, the ant-build-system doesn't compile the classes with > debug info by default. To enable line numbers etc. in the stack traces, > we'll need to add > > debug=3D"true" > > to the relevant tags, as described here: > > https://ant.apache.org/manual/Tasks/javac.html > > If you could help debug the failures, that would be nice. I will also > look as I get time. > > -- > Chris > --94eb2c11cb4806e05d0563a0bb21 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems, that moving the tests and not moving the tesreso= urces directory breaks the relatitve paths in the tests.
Tomorrow I wil= l check what happens if we also move the testresources.

2018-01-25 10:30 GMT+01:0= 0 Chris Marusich <cmmarusich@gmail.com>:
G=C3=A1bor Boskovits <boskovits@gmail.com> writes:

> Thanks for the corrections.
> Looks good to me,
> I won't send an updated patch then.
> Please commit with the modifications.

I made the modifications and also tried to enable the tests (see
attached patch), but I discovered that some of the tests are failing
(and some are passing).=C2=A0 Perhaps we should try fixing the tests while<= br> we're here?=C2=A0 If you do

=C2=A0 /pre-inst-env guix build --keep-failed java-aqute-libg

you can see the failures.=C2=A0 The build directory will be kept.=C2=A0 If = we go
to it, we can find a report of the test failures under the path:

=C2=A0 bnd-3.4.0.REL/aQute.libg/test/test-reports

Unfortunately, the ant-build-system doesn't compile the classes with debug info by default.=C2=A0 To enable line numbers etc. in the stack trace= s,
we'll need to add

=C2=A0 debug=3D"true"

to the relevant <javac> tags, as described here:

https://ant.apache.org/manual/Tasks/javac.html

If you could help debug the failures, that would be nice.=C2=A0 I will also=
look as I get time.

--
Chris

--94eb2c11cb4806e05d0563a0bb21--