unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Valentin Ignatev <valentignatev@gmail.com>
To: 38662@debbugs.gnu.org
Subject: [bug#38662] [PATCH] gnu: Add emacs-next.
Date: Thu, 19 Dec 2019 16:38:58 +0300	[thread overview]
Message-ID: <CADXmXkjP7RPSET-PkfH2TKzQEoOfTA_4JbjRQY5L14TnNwL1tA@mail.gmail.com> (raw)
In-Reply-To: <877e2tz8z5.fsf@gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 1004 bytes --]

Thanks a lot for submitting the patch, I'm eager to see emacs-next in
upstream!
However, there is a potential issue with it. Original emacs package that we
inherit here sets EMACSLOADPATH with two values, one of which is some
directory path combined with the version:
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/emacs.scm?h=master#n196

Every Emacs version creates a dir along the lines of
.gix-profile/share/emacs/version/lisp. Current emacs from master hardcodes
this version to 27.0.50, so this path becomes
.gix-profile/share/emacs/27.0.50/lisp. But since we set version based on
commit in this submitted patch, EMACSLOADPATH becomes invalid and this
specific directory doesn't end up in the guix-profile/etc/profile script,
so when you run emacs, you get multiple errors because Emacs can't load
builtin packages. I think that hardcoding a version of emacs-next to
"27.0.50" should work well. I'm attaching a patch that can be applied to
Amin's emacs-next patch.

Regards,
Valentin

[-- Attachment #1.2: Type: text/html, Size: 1263 bytes --]

[-- Attachment #2: emacs-next-hardcode-version.patch --]
[-- Type: text/x-patch, Size: 1128 bytes --]

Hardcode version in `emacs-next', use commit in `file-name'

* gnu/packages/emacs.scm (emacs-next):
Hardcode version to be 27.0.50.
Change file-name to use commit instead of version to avoid checkout collisions.

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 102754deed..86795ba046 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -221,7 +221,7 @@ languages.")
     (package
       (inherit emacs)
       (name "emacs-next")
-      (version (git-version "27" revision commit))
+      (version "27.0.50")
       (source
        (origin
          (method git-fetch)
@@ -229,7 +229,7 @@ languages.")
                (url "https://git.savannah.gnu.org/git/emacs.git")
                (commit commit)))
          (sha256 (base32 "0niamywp3cq05hqc7k693c3d12jbqbzbfgl4aza9dja0jidv4b80"))
-         (file-name (git-file-name name version))
+         (file-name (git-file-name name commit))
          (patches (search-patches "emacs27-exec-path.patch"
                                   "emacs-fix-scheme-indent-function.patch"
                                   "emacs-source-date-epoch.patch"))

  reply	other threads:[~2019-12-19 13:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 20:04 [bug#38662] [PATCH] gnu: Add emacs-next Amin Bandali
2019-12-18 20:15 ` Amin Bandali
2019-12-19 13:38   ` Valentin Ignatev [this message]
2019-12-19 14:08     ` Valentin Ignatev
2019-12-19  2:28 ` Brett Gilio
2019-12-20 21:59 ` Ludovic Courtès
2019-12-22  6:15   ` Amin Bandali
2019-12-23 18:26     ` bug#38662: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADXmXkjP7RPSET-PkfH2TKzQEoOfTA_4JbjRQY5L14TnNwL1tA@mail.gmail.com \
    --to=valentignatev@gmail.com \
    --cc=38662@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).