From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46324) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihvzE-0005jH-Eh for guix-patches@gnu.org; Thu, 19 Dec 2019 08:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihvzC-0002OK-Sm for guix-patches@gnu.org; Thu, 19 Dec 2019 08:37:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihvzC-0002Mb-Id for guix-patches@gnu.org; Thu, 19 Dec 2019 08:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihvzC-0007Nh-EJ for guix-patches@gnu.org; Thu, 19 Dec 2019 08:37:02 -0500 Subject: [bug#38662] [PATCH] gnu: Add emacs-next. Resent-Message-ID: MIME-Version: 1.0 References: <20191218200419.28836-1-bandali@gnu.org> <877e2tz8z5.fsf@gnu.org> In-Reply-To: <877e2tz8z5.fsf@gnu.org> From: Valentin Ignatev Date: Thu, 19 Dec 2019 16:38:58 +0300 Message-ID: Content-Type: multipart/mixed; boundary="00000000000074e0e2059a0ea623" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38662@debbugs.gnu.org --00000000000074e0e2059a0ea623 Content-Type: multipart/alternative; boundary="00000000000074e0e0059a0ea621" --00000000000074e0e0059a0ea621 Content-Type: text/plain; charset="UTF-8" Thanks a lot for submitting the patch, I'm eager to see emacs-next in upstream! However, there is a potential issue with it. Original emacs package that we inherit here sets EMACSLOADPATH with two values, one of which is some directory path combined with the version: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/emacs.scm?h=master#n196 Every Emacs version creates a dir along the lines of .gix-profile/share/emacs/version/lisp. Current emacs from master hardcodes this version to 27.0.50, so this path becomes .gix-profile/share/emacs/27.0.50/lisp. But since we set version based on commit in this submitted patch, EMACSLOADPATH becomes invalid and this specific directory doesn't end up in the guix-profile/etc/profile script, so when you run emacs, you get multiple errors because Emacs can't load builtin packages. I think that hardcoding a version of emacs-next to "27.0.50" should work well. I'm attaching a patch that can be applied to Amin's emacs-next patch. Regards, Valentin --00000000000074e0e0059a0ea621 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks a lot for submitting the patc= h, I'm eager to see emacs-next in upstream!
However, there is= a potential issue with it. Original emacs package that we inherit here set= s EMACSLOADPATH with two values, one of which is some directory path combin= ed with the version: https://git.savannah.gnu.org/c= git/guix.git/tree/gnu/packages/emacs.scm?h=3Dmaster#n196

=
Every Emacs version creates a dir along the lines of .gix-profil= e/share/emacs/version/lisp. Current emacs from master hardcodes this versio= n to 27.0.50, so this path becomes .gix-profile/share/emacs/27.0.50/lisp. B= ut since we set version based on commit in this submitted patch, EMACSLOADP= ATH becomes invalid and this specific directory doesn't end up in the g= uix-profile/etc/profile script, so when you run emacs, you get multiple err= ors because Emacs can't load builtin packages. I think that hardcoding = a version of emacs-next to "27.0.50" should work well. I'm at= taching a patch that can be applied to Amin's emacs-next patch.

Regards,
Valentin

--00000000000074e0e0059a0ea621-- --00000000000074e0e2059a0ea623 Content-Type: text/x-patch; charset="US-ASCII"; name="emacs-next-hardcode-version.patch" Content-Disposition: attachment; filename="emacs-next-hardcode-version.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k4crt2mw0 SGFyZGNvZGUgdmVyc2lvbiBpbiBgZW1hY3MtbmV4dCcsIHVzZSBjb21taXQgaW4gYGZpbGUtbmFt ZScKCiogZ251L3BhY2thZ2VzL2VtYWNzLnNjbSAoZW1hY3MtbmV4dCk6CkhhcmRjb2RlIHZlcnNp b24gdG8gYmUgMjcuMC41MC4KQ2hhbmdlIGZpbGUtbmFtZSB0byB1c2UgY29tbWl0IGluc3RlYWQg b2YgdmVyc2lvbiB0byBhdm9pZCBjaGVja291dCBjb2xsaXNpb25zLgoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9lbWFjcy5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3Muc2NtCmluZGV4IDEwMjc1 NGRlZWQuLjg2Nzk1YmEwNDYgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy5zY20KKysr IGIvZ251L3BhY2thZ2VzL2VtYWNzLnNjbQpAQCAtMjIxLDcgKzIyMSw3IEBAIGxhbmd1YWdlcy4i KQogICAgIChwYWNrYWdlCiAgICAgICAoaW5oZXJpdCBlbWFjcykKICAgICAgIChuYW1lICJlbWFj cy1uZXh0IikKLSAgICAgICh2ZXJzaW9uIChnaXQtdmVyc2lvbiAiMjciIHJldmlzaW9uIGNvbW1p dCkpCisgICAgICAodmVyc2lvbiAiMjcuMC41MCIpCiAgICAgICAoc291cmNlCiAgICAgICAgKG9y aWdpbgogICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCkBAIC0yMjksNyArMjI5LDcgQEAgbGFu Z3VhZ2VzLiIpCiAgICAgICAgICAgICAgICAodXJsICJodHRwczovL2dpdC5zYXZhbm5haC5nbnUu b3JnL2dpdC9lbWFjcy5naXQiKQogICAgICAgICAgICAgICAgKGNvbW1pdCBjb21taXQpKSkKICAg ICAgICAgIChzaGEyNTYgKGJhc2UzMiAiMG5pYW15d3AzY3EwNWhxYzdrNjkzYzNkMTJqYnFiemJm Z2w0YXphOWRqYTBqaWR2NGI4MCIpKQotICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFt ZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1l IGNvbW1pdCkpCiAgICAgICAgICAocGF0Y2hlcyAoc2VhcmNoLXBhdGNoZXMgImVtYWNzMjctZXhl Yy1wYXRoLnBhdGNoIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJlbWFjcy1m aXgtc2NoZW1lLWluZGVudC1mdW5jdGlvbi5wYXRjaCIKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiZW1hY3Mtc291cmNlLWRhdGUtZXBvY2gucGF0Y2giKSkK --00000000000074e0e2059a0ea623--