From: Andrew Tropin <andrew@trop.in>
To: Michael Rohleder <mike@rohleder.de>
Cc: 44555@debbugs.gnu.org
Subject: [bug#44555] [PATCH] gnu: Add emacs-next-use-package
Date: Wed, 11 Nov 2020 10:53:43 +0300 [thread overview]
Message-ID: <CABrWRW21b8OZ=5t8LVfd-W6kztr874ZH16VpG+CvGui8sp8WAw@mail.gmail.com> (raw)
In-Reply-To: <877dqtj6lj.fsf@rohleder.de>
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
Cool news: John Wiegley made a new release a few hours ago, my patch is no
longer relevant, will make another one, which just bumps the version to
2.4.1.
> Normally, we try to install optional packages per default.
> Sometimes, it's not so easy and one has to weigh up...
>
> Maybe the use-case for use-package is so that diminish is very often
> needed? Or for too many users, it would be "useless" (or break
> something), w/o it?
>
>
> Imho (I don't have commit superpower), you need a reason to remove an
> input (and here, this means provided/out of the box experience). Or at
> least make a comment in the source _why_ it isn't needed etc...
I will give you a simple example: Someone uses delight (a diminish
alternative, which also support major modes) instead of diminish and
they would install emacs-use-package and emacs-delight, but he will also
get emacs-diminsh as a dependency of emacs-use-package. To remove it
they will need to inherit emacs-use-package and update
propagated-inputs.
I think installing emacs-use-package and manually adding emacs-diminish
is easier and more fair than installing emacs-use-package+emacs-delight
and removing emacs-diminish from dependencies of emacs-use-package.
I totally agree, that diminish is a great package with a great story
inside its sources, but don't think it should be installed by default
with use-package.
I'll make a separate patch for removing propagated-inputs and related
discussion.
Bump patch in the attachment.
--
Best regards,
Andrew Tropin
[-- Attachment #2: 0001-gnu-emacs-use-package-Update-to-2.4.1.patch --]
[-- Type: text/x-patch, Size: 1351 bytes --]
From 7f725f6c1b8a0e724002ac67c5e26a8df747ad6b Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Wed, 11 Nov 2020 10:48:30 +0300
Subject: [PATCH] gnu: emacs-use-package: Update to 2.4.1
use-package 2.4 released 2 years ago and doesn't work with GNU Emacs 28.
2.4.1 contains mostly bug fixes and works with emacs-next.
---
gnu/packages/emacs-xyz.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d27d397775..b8ab78edf8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11131,7 +11131,7 @@ abbreviation of the mode line displays (lighters) of minor modes.")
(define-public emacs-use-package
(package
(name "emacs-use-package")
- (version "2.4")
+ (version "2.4.1")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -11140,7 +11140,7 @@ abbreviation of the mode line displays (lighters) of minor modes.")
(file-name (git-file-name name version))
(sha256
(base32
- "1b7mjjh0d6fmkkd9vyj64vca27xqhga0nvyrrcqxpqjn62zq046y"))))
+ "088kl3bml0rs5bkfymgzr15ram9qvy66h1kaisrbkynh0yxvf8g9"))))
(build-system emacs-build-system)
(native-inputs
`(("texinfo" ,texinfo)))
--
2.25.4
next prev parent reply other threads:[~2020-11-11 7:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:45 [bug#44555] [PATCH] gnu: Add emacs-next-use-package Andrew Tropin
2020-11-10 16:15 ` Andrew Tropin
2020-11-10 17:16 ` zimoun
2020-11-10 17:56 ` Andrew Tropin
2020-11-10 19:22 ` Michael Rohleder
2020-11-10 19:36 ` Andrew Tropin
2020-11-10 20:32 ` Michael Rohleder
2020-11-11 7:53 ` Andrew Tropin [this message]
2020-11-11 9:35 ` Nicolas Goaziou
2020-11-11 10:02 ` bug#44555: " Nicolas Goaziou
2020-11-11 14:33 ` [bug#44555] " Andrew Tropin
2020-11-10 18:00 ` Leo Prikler
2020-11-11 22:42 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABrWRW21b8OZ=5t8LVfd-W6kztr874ZH16VpG+CvGui8sp8WAw@mail.gmail.com' \
--to=andrew@trop.in \
--cc=44555@debbugs.gnu.org \
--cc=mike@rohleder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).