unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Rohleder <mike@rohleder.de>
To: Andrew Tropin <andrew@trop.in>
Cc: 44555@debbugs.gnu.org
Subject: [bug#44555] [PATCH] gnu: Add emacs-next-use-package
Date: Tue, 10 Nov 2020 21:32:24 +0100	[thread overview]
Message-ID: <877dqtj6lj.fsf@rohleder.de> (raw)
In-Reply-To: <CABrWRW1BCmfP9qC-QLxw=7=ifYi9eaBVyFxRzPqoaPf7B6RPEA@mail.gmail.com> (Andrew Tropin's message of "Tue, 10 Nov 2020 22:36:29 +0300")

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Andrew Tropin <andrew@trop.in> writes:
> There is no issue with diminish itself. I just don't know why it
> is specified as propagated-input. It's an optional dependency as
> well as delight, key-chord and many other use-package extensions
> and it should be installed explicitly by the user, not pulled as a
> dependency.
>
> Probably I had to do it with another patch to make it clearer.

Normally, we try to install optional packages per default.
Sometimes, it's not so easy and one has to weigh up...

Maybe the use-case for use-package is so that diminish is very often
needed?  Or for too many users, it would be "useless" (or break
something), w/o it?


Imho (I don't have commit superpower), you need a reason to remove an
input (and here, this means provided/out of the box experience).  Or at
least make a comment in the source _why_ it isn't needed etc...


-- 
If you can't make it good, make it LOOK good. - Bill Gates

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

  reply	other threads:[~2020-11-10 20:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 15:45 [bug#44555] [PATCH] gnu: Add emacs-next-use-package Andrew Tropin
2020-11-10 16:15 ` Andrew Tropin
2020-11-10 17:16 ` zimoun
2020-11-10 17:56   ` Andrew Tropin
2020-11-10 19:22   ` Michael Rohleder
2020-11-10 19:36     ` Andrew Tropin
2020-11-10 20:32       ` Michael Rohleder [this message]
2020-11-11  7:53         ` Andrew Tropin
2020-11-11  9:35           ` Nicolas Goaziou
2020-11-11 10:02           ` bug#44555: " Nicolas Goaziou
2020-11-11 14:33             ` [bug#44555] " Andrew Tropin
2020-11-10 18:00 ` Leo Prikler
2020-11-11 22:42   ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dqtj6lj.fsf@rohleder.de \
    --to=mike@rohleder.de \
    --cc=44555@debbugs.gnu.org \
    --cc=andrew@trop.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).