unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39966] [PATCH 0/3] add compiledb
@ 2020-03-07  3:30 Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 1/3] gnu: Add python-bashlex Yuval Kogman
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-07  3:30 UTC (permalink / raw)
  To: 39966

This patchset adds the compiledb, which is similar to bear.

FWIW, I was having trouble using bear (seems to segfault during ld
preload, before main(), so I was unable to generate a stacktrace).

Yuval Kogman (3):
  gnu: Add python-bashlex.
  gnu: Add python-shutilwhich.
  gnu: Add python-compiledb.

 gnu/packages/build-tools.scm | 30 ++++++++++++++++++++
 gnu/packages/python-xyz.scm  | 66 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 96 insertions(+)

--
2.11.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 1/3] gnu: Add python-bashlex.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
@ 2020-03-07  4:22 ` Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 2/3] gnu: Add python-shutilwhich Yuval Kogman
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-07  4:22 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
* gnu/packages/python-xyz.scm (python2-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

[-- Attachment #2: 0001-gnu-Add-python-bashlex.patch --]
[-- Type: application/x-patch, Size: 1727 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 2/3] gnu: Add python-shutilwhich.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 1/3] gnu: Add python-bashlex Yuval Kogman
@ 2020-03-07  4:22 ` Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 3/3] gnu: Add python-compiledb Yuval Kogman
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-07  4:22 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

* gnu/packages/python-xyz.scm (python-shutilwhich): New variable.
* gnu/packages/python-xyz.scm (python2-shutilwhich): New variable.
---
 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

[-- Attachment #2: 0002-gnu-Add-python-shutilwhich.patch --]
[-- Type: application/x-patch, Size: 1082 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 3/3] gnu: Add python-compiledb.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 1/3] gnu: Add python-bashlex Yuval Kogman
  2020-03-07  4:22 ` [bug#39966] [PATCH 2/3] gnu: Add python-shutilwhich Yuval Kogman
@ 2020-03-07  4:22 ` Yuval Kogman
  2020-03-11 19:12 ` [bug#39966] [PATCH 0/3] add compiledb Leo Famulari
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-07  4:22 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

* gnu/packages/built-tools.scm (python-compiledb): New variable.
---
 gnu/packages/build-tools.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

[-- Attachment #2: 0003-gnu-Add-python-compiledb.patch --]
[-- Type: application/x-patch, Size: 2083 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 0/3] add compiledb
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
                   ` (2 preceding siblings ...)
  2020-03-07  4:22 ` [bug#39966] [PATCH 3/3] gnu: Add python-compiledb Yuval Kogman
@ 2020-03-11 19:12 ` Leo Famulari
  2020-03-12  0:58   ` Yuval Kogman
  2020-03-12  0:56 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 11+ messages in thread
From: Leo Famulari @ 2020-03-11 19:12 UTC (permalink / raw)
  To: Yuval Kogman; +Cc: 39966

On Sat, Mar 07, 2020 at 03:30:20AM +0000, Yuval Kogman wrote:
> This patchset adds the compiledb, which is similar to bear.
> 
> FWIW, I was having trouble using bear (seems to segfault during ld
> preload, before main(), so I was unable to generate a stacktrace).
> 
> Yuval Kogman (3):
>   gnu: Add python-bashlex.
>   gnu: Add python-shutilwhich.
>   gnu: Add python-compiledb.

Thanks!

Unless you specifically need the Python 2 variants of bashlex and
shutilwhich, we can omit them. We are not adding Python 2 package
variants by default anymore.

I wonder about shutilwhich, which is a backport of a feature from
Python 3.3. We are using Python 3.7 so this should not be necessary,
right? Does compiledb require it specifically?

Can you send a revised patch series addressing this feedback? And when
you do, please make sure to add copyright lines for yourself to the
files you edit, and generate the patches using `git format-patch`, or
even `git send-email`, sending the mail to this bug report address.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 1/2] gnu: Add python-bashlex.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
                   ` (3 preceding siblings ...)
  2020-03-11 19:12 ` [bug#39966] [PATCH 0/3] add compiledb Leo Famulari
@ 2020-03-12  0:56 ` Yuval Kogman
  2020-03-12  0:56 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-12  0:56 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

[-- Attachment #2: 0001-gnu-Add-python-bashlex.patch --]
[-- Type: application/x-patch, Size: 1449 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 2/2] gnu: Add compiledb.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
                   ` (4 preceding siblings ...)
  2020-03-12  0:56 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
@ 2020-03-12  0:56 ` Yuval Kogman
  2020-03-12  1:02 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
  2020-03-12  1:02 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-12  0:56 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

* gnu/packages/built-tools.scm (compiledb): New variable.
---
 gnu/packages/build-tools.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

[-- Attachment #2: 0002-gnu-Add-compiledb.patch --]
[-- Type: application/x-patch, Size: 2395 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 0/3] add compiledb
  2020-03-11 19:12 ` [bug#39966] [PATCH 0/3] add compiledb Leo Famulari
@ 2020-03-12  0:58   ` Yuval Kogman
  0 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-12  0:58 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 39966

oops, i forgot to update the copyright again, sorry for the spam

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 1/2] gnu: Add python-bashlex.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
                   ` (5 preceding siblings ...)
  2020-03-12  0:56 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman
@ 2020-03-12  1:02 ` Yuval Kogman
  2020-05-29  0:32   ` bug#39966: " Leo Famulari
  2020-03-12  1:02 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman
  7 siblings, 1 reply; 11+ messages in thread
From: Yuval Kogman @ 2020-03-12  1:02 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

* gnu/packages/python-xyz.scm (python-bashlex): New variable.
---
 gnu/packages/python-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

[-- Attachment #2: 0001-gnu-Add-python-bashlex.patch --]
[-- Type: application/x-patch, Size: 1785 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#39966] [PATCH 2/2] gnu: Add compiledb.
  2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
                   ` (6 preceding siblings ...)
  2020-03-12  1:02 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
@ 2020-03-12  1:02 ` Yuval Kogman
  7 siblings, 0 replies; 11+ messages in thread
From: Yuval Kogman @ 2020-03-12  1:02 UTC (permalink / raw)
  To: 39966

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

* gnu/packages/built-tools.scm (compiledb): New variable.
---
 gnu/packages/build-tools.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

[-- Attachment #2: 0002-gnu-Add-compiledb.patch --]
[-- Type: application/x-patch, Size: 2710 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#39966: [PATCH 1/2] gnu: Add python-bashlex.
  2020-03-12  1:02 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
@ 2020-05-29  0:32   ` Leo Famulari
  0 siblings, 0 replies; 11+ messages in thread
From: Leo Famulari @ 2020-05-29  0:32 UTC (permalink / raw)
  To: Yuval Kogman; +Cc: 39966-done

On Thu, Mar 12, 2020 at 01:02:02AM +0000, Yuval Kogman wrote:
> * gnu/packages/python-xyz.scm (python-bashlex): New variable.

After waaaaaay too long, I pushed your patches as
6560c4976f775db5b494356df2beaa0fcec6f9c0

I'm sorry about the delay. We really need to improve how long it takes
to review patches :/




^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-05-29  0:33 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-07  3:30 [bug#39966] [PATCH 0/3] add compiledb Yuval Kogman
2020-03-07  4:22 ` [bug#39966] [PATCH 1/3] gnu: Add python-bashlex Yuval Kogman
2020-03-07  4:22 ` [bug#39966] [PATCH 2/3] gnu: Add python-shutilwhich Yuval Kogman
2020-03-07  4:22 ` [bug#39966] [PATCH 3/3] gnu: Add python-compiledb Yuval Kogman
2020-03-11 19:12 ` [bug#39966] [PATCH 0/3] add compiledb Leo Famulari
2020-03-12  0:58   ` Yuval Kogman
2020-03-12  0:56 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
2020-03-12  0:56 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman
2020-03-12  1:02 ` [bug#39966] [PATCH 1/2] gnu: Add python-bashlex Yuval Kogman
2020-05-29  0:32   ` bug#39966: " Leo Famulari
2020-03-12  1:02 ` [bug#39966] [PATCH 2/2] gnu: Add compiledb Yuval Kogman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).