unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Robert Smith" <robertsmith@posteo.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39367@debbugs.gnu.org
Subject: [bug#39367] [PATCH] gnu: Add anki.
Date: Mon, 03 Feb 2020 17:11:20 +0100	[thread overview]
Message-ID: <C0CNSGDPWDLG.2ASM1G2P9DXHU@amber> (raw)
In-Reply-To: <87zhe1b0so.fsf@nicolasgoaziou.fr>

On Sun Feb 2, 2020 at 2:01 PM Nicolas Goaziou wrote:
> > +     '(#:make-flags (list (string-append "PREFIX=" %output))
> 
> OOC, isn't it automatic in gnu-build-system?

For some reason I thought that this usually happened in the configure
stage, which I deleted. You're probably right, I'll double-check and fix
if necessary.

> Please order inputs and propagated-inputs alphabetically.

Will fix!
 
> The package builds fine, but when trying to run "anki", I get the
> following error:
> 
>   ModuleNotFoundError: No module named 'decorator'
> 
> It looks like you also need to wrap PYTHONPATH around the executable. WDYT?

Since Anki uses python at run time, is the proper action to wrap the
executable with the desired pythonpath, or to declare python as a
propagated input? Propagating python sounds simpler, but would likely be
inconvienent for users who need custom python versions. I'll look into
wrapping PYTHONPATH and I will resubmit. Thank you for reviewing my
patch!

Best,

Robert

  reply	other threads:[~2020-02-03 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 12:01 [bug#39367] [PATCH] gnu: Add anki Robert Smith
2020-02-02 13:01 ` Nicolas Goaziou
2020-02-03 16:11   ` Robert Smith [this message]
2020-02-03 16:18     ` Nicolas Goaziou
2020-02-04 12:01 ` [bug#39367] [PATCH v2] " Robert Smith
2020-02-05 14:03   ` bug#39367: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C0CNSGDPWDLG.2ASM1G2P9DXHU@amber \
    --to=robertsmith@posteo.net \
    --cc=39367@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).