From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:42944)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyeKR-0007sy-8T
 for guix-patches@gnu.org; Mon, 03 Feb 2020 11:12:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyeKQ-00042b-AC
 for guix-patches@gnu.org; Mon, 03 Feb 2020 11:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:36154)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iyeKP-00041g-SL
 for guix-patches@gnu.org; Mon, 03 Feb 2020 11:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyeKP-0000yA-OG
 for guix-patches@gnu.org; Mon, 03 Feb 2020 11:12:01 -0500
Subject: [bug#39367] [PATCH] gnu: Add anki.
References: <20200131120112.4532-1-robertsmith@posteo.net>
Resent-Message-ID: <handler.39367.B39367.15807462913686@debbugs.gnu.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <87zhe1b0so.fsf@nicolasgoaziou.fr>
Date: Mon, 03 Feb 2020 17:11:20 +0100
From: "Robert Smith" <robertsmith@posteo.net>
Message-Id: <C0CNSGDPWDLG.2ASM1G2P9DXHU@amber>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39367@debbugs.gnu.org

On Sun Feb 2, 2020 at 2:01 PM Nicolas Goaziou wrote:
> > +     '(#:make-flags (list (string-append "PREFIX=3D" %output))
>=20
> OOC, isn't it automatic in gnu-build-system?

For some reason I thought that this usually happened in the configure
stage, which I deleted. You're probably right, I'll double-check and fix
if necessary.

> Please order inputs and propagated-inputs alphabetically.

Will fix!
=20
> The package builds fine, but when trying to run "anki", I get the
> following error:
>=20
>   ModuleNotFoundError: No module named 'decorator'
>=20
> It looks like you also need to wrap PYTHONPATH around the executable. WDY=
T?

Since Anki uses python at run time, is the proper action to wrap the
executable with the desired pythonpath, or to declare python as a
propagated input? Propagating python sounds simpler, but would likely be
inconvienent for users who need custom python versions. I'll look into
wrapping PYTHONPATH and I will resubmit. Thank you for reviewing my
patch!

Best,

Robert