unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#52861] [PATCH] gnu: python-cssselect2: Fix build.
@ 2021-12-28 21:37 Morgan.J.Smith
  2021-12-29 23:16 ` bug#52861: " Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Morgan.J.Smith @ 2021-12-28 21:37 UTC (permalink / raw)
  To: 52861; +Cc: Morgan Smith

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/python-web.scm (python-cssselect2)
[phases]: Add disable-linters phase.  Make check phase respect #:tests?
[native-inputs]: Remove python-pytest-flake8 and python-pytest-isort
---
 gnu/packages/python-web.scm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 61a34bfc63..f424c6a103 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4582,13 +4582,22 @@ (define-public python-cssselect2
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'disable-linters
+           ;; Their check fails; none of our business.
+           (lambda _
+             (substitute* '("setup.py" "pyproject.toml")
+               (("'pytest-flake8',") "")
+               (("'pytest-isort',") "")
+               (("--flake8") "")
+               (("--isort") ""))))
          (replace 'check
-           (lambda _ (invoke "pytest"))))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (lambda _ (invoke "pytest"))))))))
     (propagated-inputs
      (list python-tinycss2))
     (native-inputs
-     (list python-pytest-cov python-pytest-flake8 python-pytest-isort
-           python-pytest-runner))
+     (list python-pytest-cov python-pytest-runner))
     (home-page "https://cssselect2.readthedocs.io/")
     (synopsis "CSS selectors for Python ElementTree")
     (description "@code{cssselect2} is a straightforward implementation of
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#52861: [PATCH] gnu: python-cssselect2: Fix build.
  2021-12-28 21:37 [bug#52861] [PATCH] gnu: python-cssselect2: Fix build Morgan.J.Smith
@ 2021-12-29 23:16 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2021-12-29 23:16 UTC (permalink / raw)
  To: Morgan.J.Smith; +Cc: 52861-done

Hello,

Morgan.J.Smith@outlook.com writes:
>
> * gnu/packages/python-web.scm (python-cssselect2)
> [phases]: Add disable-linters phase.  Make check phase respect #:tests?
> [native-inputs]: Remove python-pytest-flake8 and python-pytest-isort

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-29 23:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-28 21:37 [bug#52861] [PATCH] gnu: python-cssselect2: Fix build Morgan.J.Smith
2021-12-29 23:16 ` bug#52861: " Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).