From: Roel Janssen <roel@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 55538@debbugs.gnu.org
Subject: [bug#55538] [PATCH] gnu: virtuoso-ose: Update to 7.2.7.
Date: Wed, 25 May 2022 17:51:27 +0200 [thread overview]
Message-ID: <9b71e2c249653a74c0e039670d5a60492c9c2eb0.camel@gnu.org> (raw)
In-Reply-To: <875ylt4rep.fsf@gmail.com>
On Wed, 2022-05-25 at 10:29 -0400, Maxim Cournoyer wrote:
> Hi Roel,
>
> Roel Janssen <roel@gnu.org> writes:
>
> > Dear Guix,
> >
> > I'd like to update Virtuoso OSE to the latest release (see attached patch).
> >
> > Other than the version number and checksum bump I noticed that some JAR files made it in the
> > build
> > output. I tried removing them from the source tarball using a snippet, but then one needs to
> > include a patch for various Makefile.am files and run the autogen.sh script. I thought this was
> > simpler and clearer on what's actually achieved.
>
> I fear in the future it would be easy to overlook the introduction of
> extra bundled jars in the source, that'd get installed. I feel it'd be
> preferable if we removed them all from a source snippet, at the cost of
> having to patch the build system (the extra complications you
> mentioned).
>
> Could you try it and send a revised patch?
>
Thank you for taking a look at it! To be fair, what the patches would do, would be to avoid
including the directories that I remove. So removing the current pre-built binaries in a snippet
will be equally error-prone.
But I agree that you would preferably want to have a source tarball without pre-built binaries in it
when running `guix build -S virtuoso-ose`.
A naive patch leads to the build getting stuck, so I need to investigate the impact further.
I'll report back when I have adapted the patch.
THank you again for your time!
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2022-05-25 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:41 [bug#55538] [PATCH] gnu: virtuoso-ose: Update to 7.2.7 Roel Janssen
2022-05-25 14:29 ` Maxim Cournoyer
2022-05-25 15:51 ` Roel Janssen [this message]
2022-05-27 10:47 ` Roel Janssen
2022-05-29 12:44 ` Efraim Flashner
2022-05-29 21:55 ` Roel Janssen
2022-05-30 6:21 ` Efraim Flashner
2022-05-30 7:09 ` bug#55538: " Roel Janssen
2022-05-31 13:44 ` [bug#55538] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b71e2c249653a74c0e039670d5a60492c9c2eb0.camel@gnu.org \
--to=roel@gnu.org \
--cc=55538@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).