From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QFvjF6pQjmKrkAAAbAwnHQ (envelope-from ) for ; Wed, 25 May 2022 17:52:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UE3dFqpQjmIPWgAAG6o9tA (envelope-from ) for ; Wed, 25 May 2022 17:52:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D093137ACF for ; Wed, 25 May 2022 17:52:09 +0200 (CEST) Received: from localhost ([::1]:49726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nttIu-0007po-P1 for larch@yhetil.org; Wed, 25 May 2022 11:52:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nttIo-0007pP-8j for guix-patches@gnu.org; Wed, 25 May 2022 11:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nttIo-0002fK-0O for guix-patches@gnu.org; Wed, 25 May 2022 11:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nttIn-00034P-VS for guix-patches@gnu.org; Wed, 25 May 2022 11:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55538] [PATCH] gnu: virtuoso-ose: Update to 7.2.7. Resent-From: Roel Janssen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 May 2022 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55538 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 55538@debbugs.gnu.org Received: via spool by 55538-submit@debbugs.gnu.org id=B55538.165349390111762 (code B ref 55538); Wed, 25 May 2022 15:52:01 +0000 Received: (at 55538) by debbugs.gnu.org; 25 May 2022 15:51:41 +0000 Received: from localhost ([127.0.0.1]:56295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nttIR-00033a-Ql for submit@debbugs.gnu.org; Wed, 25 May 2022 11:51:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nttIO-00033L-Qv for 55538@debbugs.gnu.org; Wed, 25 May 2022 11:51:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nttIJ-0002eX-Cn; Wed, 25 May 2022 11:51:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:To:From: Subject; bh=SmsSaidLU8AAVAzTsJSjJol8A3MeEaGyeZf6NJFF0pA=; b=oAknVZlAodRcpbGje DybMn8rCErsVCgNS+25ncEW5WMZH3ZzUwZ93kPEQRVZCoY57YIp29J3buVyXi0O4LbQNSdaV81aZ3 NfB8nillntoTK7s7kbxZEkbBFJVxC3aR8AFDNsvN7o94uEBHoUyEJ3yDU1eB9karJWdfU2zn9evbw qkSOe/raGXt47h58xA+yja7IPZyZZYipTAE2JIRq1sQC7PdhkV0ebym/XWG9IWb9qRKFT/UU6pUi4 MSo8+chIwbnt93j+FmDK9NLTkBfM6F5nUc9VdXoGn69+wKai4AShovKrhdanIEF/rnq2SKq3rRsw8 6CS1xg0tJOn6YuRVA==; Received: from 2a02-a46b-9fc4-1-d864-ee57-c9d9-98a0.fixed6.kpn.net ([2a02:a46b:9fc4:1:d864:ee57:c9d9:98a0]:55386) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nttIJ-0003EC-0J; Wed, 25 May 2022 11:51:31 -0400 Message-ID: <9b71e2c249653a74c0e039670d5a60492c9c2eb0.camel@gnu.org> From: Roel Janssen Date: Wed, 25 May 2022 17:51:27 +0200 In-Reply-To: <875ylt4rep.fsf@gmail.com> References: <875ylt4rep.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653493930; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SmsSaidLU8AAVAzTsJSjJol8A3MeEaGyeZf6NJFF0pA=; b=U8CsJT51rp8e+4FdfHXt4pjLyZKPP36bk/JAksyKNMBhspG4+HyLi9T80QwgDuszuspmN0 dw3z4WMAA1cDIRWsJAdPJbM0ntd1XpFKUznD1K1vG+LB8QRIEejuH2LhzfR+1WjfWw8xvF bIH0sBtW646WD+zBlwfGq5SVEtYMfx9/ezNkMbk8wrFyHgRTJ988zL2C207X/hJbAZvAmh p4Pb5Sfs9QSklFEIihsmAzs7Ggeol+n/2az/BPpWwV9J0ge2+o7oqgj4YGPoPFV8kYClA8 A46yqt0Df8Ai1CE59FZ+Radd8BXEGv1vGd3+geAOTvw77GiPK5eew2IE+Sqi2g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653493930; a=rsa-sha256; cv=none; b=L/BFD+2jzbe/DJk/qIfGF9PB7+mX0pFy8V2jBC5bAS4N0NFPmiBbYscptwHKJFmey7bQ/E AOTWBBGdlHpE+d5lP5MIsDYOOv0169zDgWiKicIaXUVzl7bKz3F77nvrBkyD1boCuvIIzf 0vwyyOGZzEfFyQ06RPhYHaljE0ThkGlHo5vSL09rTQu26Zc/weR1k0MU9svbdhCnefdEJ0 T8qE2F8NY/t6tGzXaP+jxFZFAuSS2s2H8eniZ2bwCF4tcssuGH+7rNBEWetrCg0+SF8cQi 6T/cY6+qoQRzBs7g9MPBp94xnnp3FEQGZre6IbJ7Al+QSHE2i2TvMvAPck9taQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=oAknVZlA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=oAknVZlA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D093137ACF X-Spam-Score: -4.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: oWEfbF61H+KG On Wed, 2022-05-25 at 10:29 -0400, Maxim Cournoyer wrote: > Hi Roel, >=20 > Roel Janssen writes: >=20 > > Dear Guix, > >=20 > > I'd like to update Virtuoso OSE to the latest release (see attached pat= ch). > >=20 > > Other than the version number and checksum bump I noticed that some JAR= files made it in the > > build > > output.=C2=A0 I tried removing them from the source tarball using a sni= ppet, but then one needs to > > include a patch for various Makefile.am files and run the autogen.sh sc= ript.=C2=A0 I thought this was > > simpler and clearer on what's actually achieved. >=20 > I fear in the future it would be easy to overlook the introduction of > extra bundled jars in the source, that'd get installed.=C2=A0 I feel it'd= be > preferable if we removed them all from a source snippet, at the cost of > having to patch the build system (the extra complications you > mentioned). >=20 > Could you try it and send a revised patch? >=20 Thank you for taking a look at it! To be fair, what the patches would do, w= ould be to avoid including the directories that I remove. So removing the current pre-built = binaries in a snippet will be equally error-prone. But I agree that you would preferably want to have a source tarball without= pre-built binaries in it when running `guix build -S virtuoso-ose`. A naive patch leads to the build getting stuck, so I need to investigate th= e impact further. I'll report back when I have adapted the patch. THank you again for your time! Kind regards, Roel Janssen